From: Simon Horman <simon.horman@netronome.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
oss-drivers@netronome.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang
Date: Fri, 5 Mar 2021 13:19:50 +0100 [thread overview]
Message-ID: <20210305121949.GF8899@netronome.com> (raw)
In-Reply-To: <20210305094937.GA141307@embeddedor>
On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks Gustavo,
this looks good to me.
Acked-by: Simon Horman <simon.horman@netronome.com>
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> index b3cabc274121..3b8e675087de 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
> case NFP_PORT_PF_PORT:
> case NFP_PORT_VF_PORT:
> nfp_repr_vnic_get_stats64(repr->port, stats);
> + break;
> default:
> break;
> }
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-03-05 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 9:49 [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-05 12:19 ` Simon Horman [this message]
2021-04-20 20:23 ` Gustavo A. R. Silva
2021-04-21 9:39 ` [oss-drivers] " Simon Horman
2021-05-18 0:07 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305121949.GF8899@netronome.com \
--to=simon.horman@netronome.com \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).