From: Vladimir Oltean <olteanv@gmail.com>
To: George McCollister <george.mccollister@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: xrs700x: check if partner is same as port in hsr join
Date: Tue, 9 Mar 2021 02:10:52 +0200 [thread overview]
Message-ID: <20210309001052.jxta3e7eilkgo64u@skbuf> (raw)
In-Reply-To: <20210308233822.59729-1-george.mccollister@gmail.com>
On Mon, Mar 08, 2021 at 05:38:22PM -0600, George McCollister wrote:
> Don't assign dp to partner if it's the same port that xrs700x_hsr_join
> was called with. The partner port is supposed to be the other port in
> the HSR/PRP redundant pair not the same port. This fixes an issue
> observed in testing where forwarding between redundant HSR ports on this
> switch didn't work depending on the order the ports were added to the
> hsr device.
>
> Fixes: bd62e6f5e6a9 ("net: dsa: xrs700x: add HSR offloading support")
> Signed-off-by: George McCollister <george.mccollister@gmail.com>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
next prev parent reply other threads:[~2021-03-09 0:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 23:38 [PATCH net] net: dsa: xrs700x: check if partner is same as port in hsr join George McCollister
2021-03-09 0:10 ` Vladimir Oltean [this message]
2021-03-10 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309001052.jxta3e7eilkgo64u@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox