From: Vladimir Oltean <olteanv@gmail.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Tobias Waldekranz <tobias@waldekranz.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net] net: dsa: only unset VLAN filtering when last port leaves last VLAN-aware bridge
Date: Tue, 9 Mar 2021 10:57:10 +0200 [thread overview]
Message-ID: <20210309085710.xdo2h6xmm3oamdks@skbuf> (raw)
In-Reply-To: <87r1kon8hu.fsf@kurt>
On Tue, Mar 09, 2021 at 07:31:25AM +0100, Kurt Kanzenbach wrote:
> > @@ -124,13 +124,16 @@ static int dsa_switch_bridge_leave(struct dsa_switch *ds,
> > * it. That is a good thing, because that lets us handle it and also
> > * handle the case where the switch's vlan_filtering setting is global
> > * (not per port). When that happens, the correct moment to trigger the
> > - * vlan_filtering callback is only when the last port left this bridge.
> > + * vlan_filtering callback is only when the last port the last
>
> Somehow "left" got missing. Shouldn't that line be:
>
> "vlan_filtering callback is only when the last port left the last" ?
>
Thanks, you're right, I don't know how it happened, I'll resend.
next prev parent reply other threads:[~2021-03-09 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 13:55 [PATCH net] net: dsa: only unset VLAN filtering when last port leaves last VLAN-aware bridge Vladimir Oltean
2021-03-09 6:31 ` Kurt Kanzenbach
2021-03-09 8:57 ` Vladimir Oltean [this message]
2021-03-10 18:45 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309085710.xdo2h6xmm3oamdks@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox