From: Willy Tarreau <w@1wt.eu>
To: Claudiu.Beznea@microchip.com
Cc: schwab@linux-m68k.org, linux-riscv@lists.infradead.org,
ckeepax@opensource.cirrus.com, andrew@lunn.ch,
Nicolas.Ferre@microchip.com, daniel@0x0f.com,
alexandre.belloni@bootlin.com, pthombar@cadence.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: macb broken on HiFive Unleashed
Date: Wed, 10 Mar 2021 17:17:16 +0100 [thread overview]
Message-ID: <20210310161716.GB17851@1wt.eu> (raw)
In-Reply-To: <04a7e801-9a55-c926-34ad-3a7665077a4e@microchip.com>
Hi,
On Tue, Mar 09, 2021 at 08:55:10AM +0000, Claudiu.Beznea@microchip.com wrote:
> Hi Andreas,
>
> On 08.03.2021 21:30, Andreas Schwab wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > One of the changes to the macb driver between 5.10 and 5.11 has broken
> > the SiFive HiFive Unleashed. These are the last messages before the
> > system hangs:
> >
> > [ 12.468674] libphy: Fixed MDIO Bus: probed
> > [ 12.746518] macb 10090000.ethernet: Registered clk switch 'sifive-gemgxl-mgmt'
> > [ 12.753119] macb 10090000.ethernet: GEM doesn't support hardware ptp.
> > [ 12.760178] libphy: MACB_mii_bus: probed
> > [ 12.881792] MACsec IEEE 802.1AE
> > [ 12.944426] macb 10090000.ethernet eth0: Cadence GEM rev 0x10070109 at 0x10090000 irq 16 (70:b3:d5:92:f1:07)
> >
>
> I don't have a SiFive HiFive Unleashed to investigate this. Can you check
> if reverting commits on macb driver b/w 5.10 and 5.11 solves your issues:
>
> git log --oneline v5.10..v5.11 -- drivers/net/ethernet/cadence/
> 1d0d561ad1d7 net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag
> 1d608d2e0d51 Revert "macb: support the two tx descriptors on at91rm9200"
> 700d566e8171 net: macb: add support for sama7g5 emac interface
> ec771de654e4 net: macb: add support for sama7g5 gem interface
> f4de93f03ed8 net: macb: unprepare clocks in case of failure
> 38493da4e6a8 net: macb: add function to disable all macb clocks
> daafa1d33cc9 net: macb: add capability to not set the clock rate
> edac63861db7 net: macb: add userio bits as platform configuration
> 9e6cad531c9d net: macb: Fix passing zero to 'PTR_ERR'
> 0012eeb370f8 net: macb: fix NULL dereference due to no pcs_config method
> e4e143e26ce8 net: macb: add support for high speed interface
In addition, it's worth mentioning that the driver has multiple rx/tx/irq
functions depending on the platforms or chip variants, and that based on
this it should be easy to further reduce this list.
Just my two cents,
Willy
next prev parent reply other threads:[~2021-03-10 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 19:30 macb broken on HiFive Unleashed Andreas Schwab
2021-03-09 8:55 ` Claudiu.Beznea
2021-03-10 16:17 ` Willy Tarreau [this message]
2021-03-10 19:55 ` Andreas Schwab
2021-03-13 21:54 ` Emil Renner Berthing
2021-03-14 7:19 ` Andreas Schwab
2021-03-17 16:26 ` Andreas Schwab
2021-03-19 8:28 ` Yixun Lan
2021-03-19 8:42 ` Yixun Lan
2021-03-19 8:51 ` Andreas Schwab
2021-03-19 22:25 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310161716.GB17851@1wt.eu \
--to=w@1wt.eu \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=ckeepax@opensource.cirrus.com \
--cc=daniel@0x0f.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pthombar@cadence.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).