From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67AC9C433E6 for ; Thu, 11 Mar 2021 20:33:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29A1564ECD for ; Thu, 11 Mar 2021 20:33:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbhCKUdL (ORCPT ); Thu, 11 Mar 2021 15:33:11 -0500 Received: from mga05.intel.com ([192.55.52.43]:34284 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230454AbhCKUcf (ORCPT ); Thu, 11 Mar 2021 15:32:35 -0500 IronPort-SDR: VVghjzSiHlNMzfdtr3N+xwsQkJLMdFEJMZTQKjGlEjVLz7QJ28cTdOuZXQ3/tvMoPpovu/gg0K zOGO6tWiHAWg== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="273776822" X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="273776822" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 12:32:34 -0800 IronPort-SDR: 8xNhb8wMcbUS77T52NVrxn7TvEEBcUq3HgASnvdPs2ySDrE05KoWH6NFqJDrxPfOx86BxTu34B SkoOJuQVEZ1w== X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="438277275" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.251.18.194]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 12:32:30 -0800 Date: Thu, 11 Mar 2021 12:32:29 -0800 From: Jesse Brandeburg To: Alexander Duyck Cc: "kuba@kernel.org" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" , "simon.horman@netronome.com" , "yisen.zhuang@huawei.com" , "salil.mehta@huawei.com" , "intel-wired-lan@lists.osuosl.org" , "Nguyen, Anthony L" , "drivers@pensando.io" , "snelson@pensando.io" , "netanel@amazon.com" , "akiyano@amazon.com" , "gtzalik@amazon.com" , "saeedb@amazon.com" , "GR-Linux-NIC-Dev@marvell.com" , "skalluru@marvell.com" , "rmody@marvell.com" , "kys@microsoft.com" , "haiyangz@microsoft.com" , "sthemmin@microsoft.com" , "wei.liu@kernel.org" , "mst@redhat.com" , "jasowang@redhat.com" , "pv-drivers@vmware.com" , "doshir@vmware.com" , "alexanderduyck@fb.com" Subject: Re: [RFC PATCH 02/10] intel: Update drivers to use ethtool_gsprintf Message-ID: <20210311123229.00007580@intel.com> In-Reply-To: <161542652605.13546.13143472024905128153.stgit@localhost.localdomain> References: <161542634192.13546.4185974647834631704.stgit@localhost.localdomain> <161542652605.13546.13143472024905128153.stgit@localhost.localdomain> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Alexander Duyck wrote: > From: Alexander Duyck > > Update the Intel drivers to make use of ethtool_gsprintf. The general idea > is to reduce code size and overhead by replacing the repeated pattern of > string printf statements and ETH_STRING_LEN counter increments. > > Signed-off-by: Alexander Duyck > --- > drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 16 ++---- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 55 +++++++--------------- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 40 ++++++---------- > drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 40 ++++++---------- > 4 files changed, 50 insertions(+), 101 deletions(-) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > index c70dec65a572..932c6635cfd6 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > @@ -2368,21 +2368,15 @@ static void i40e_get_priv_flag_strings(struct net_device *netdev, u8 *data) > struct i40e_netdev_priv *np = netdev_priv(netdev); > struct i40e_vsi *vsi = np->vsi; > struct i40e_pf *pf = vsi->back; > - char *p = (char *)data; > + u8 *p = data; > unsigned int i; As Jakub said, RCT... :-) no other comments on the rest of the patch, looks good and Thanks!