From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"oss-drivers@netronome.com" <oss-drivers@netronome.com>,
"simon.horman@netronome.com" <simon.horman@netronome.com>,
"yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>,
"salil.mehta@huawei.com" <salil.mehta@huawei.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"drivers@pensando.io" <drivers@pensando.io>,
"snelson@pensando.io" <snelson@pensando.io>,
"netanel@amazon.com" <netanel@amazon.com>,
"akiyano@amazon.com" <akiyano@amazon.com>,
"gtzalik@amazon.com" <gtzalik@amazon.com>,
"saeedb@amazon.com" <saeedb@amazon.com>,
"GR-Linux-NIC-Dev@marvell.com" <GR-Linux-NIC-Dev@marvell.com>,
"skalluru@marvell.com" <skalluru@marvell.com>,
"rmody@marvell.com" <rmody@marvell.com>,
"kys@microsoft.com" <kys@microsoft.com>,
"haiyangz@microsoft.com" <haiyangz@microsoft.com>,
"sthemmin@microsoft.com" <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"mst@redhat.com" <mst@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"pv-drivers@vmware.com" <pv-drivers@vmware.com>,
"doshir@vmware.com" <doshir@vmware.com>,
"alexanderduyck@fb.com" <alexanderduyck@fb.com>
Subject: Re: [RFC PATCH 01/10] ethtool: Add common function for filling out strings
Date: Thu, 11 Mar 2021 12:37:21 -0800 [thread overview]
Message-ID: <20210311123721.00005913@intel.com> (raw)
In-Reply-To: <20210310180807.5fb1752d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub Kicinski wrote:
> On Wed, 10 Mar 2021 17:35:17 -0800 Alexander Duyck wrote:
> > From: Alexander Duyck <alexanderduyck@fb.com>
> > +/**
> > + * ethtool_gsprintf - Write formatted string to ethtool string data
> > + * @data: Pointer to start of string to update
> > + * @fmt: Format of string to write
> > + *
> > + * Write formatted string to data. Update data to point at start of
> > + * next string.
> > + */
> > +extern __printf(2, 3) void ethtool_gsprintf(u8 **data, const char *fmt, ...);
>
> I'd drop the 'g' TBH, it seems to have made its way from the ethtool
> command ('gstrings') to various places but without the 'string' after
> it - it becomes less and less meaningful. Just ethtool_sprintf() would
> be fine IMHO.
>
> Other than that there is a minor rev xmas tree violation in patch 2 :)
I agree with Jakub, and I really like this series, it's a good clean up.
I'll be glad to add a reviewed by tag to v2.
next prev parent reply other threads:[~2021-03-11 20:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 1:35 [RFC PATCH 00/10] ethtool: Factor out common code related to writing ethtool strings Alexander Duyck
2021-03-11 1:35 ` [RFC PATCH 01/10] ethtool: Add common function for filling out strings Alexander Duyck
2021-03-11 2:08 ` Jakub Kicinski
2021-03-11 20:37 ` Jesse Brandeburg [this message]
2021-03-11 1:35 ` [RFC PATCH 02/10] intel: Update drivers to use ethtool_gsprintf Alexander Duyck
2021-03-11 20:32 ` Jesse Brandeburg
2021-03-11 1:35 ` [RFC PATCH 03/10] nfp: Replace nfp_pr_et with ethtool_gsprintf Alexander Duyck
2021-03-11 11:51 ` Simon Horman
2021-03-11 1:35 ` [RFC PATCH 04/10] hisilicon: Update drivers to use ethtool_gsprintf Alexander Duyck
2021-03-11 1:35 ` [RFC PATCH 05/10] ena: Update driver " Alexander Duyck
2021-03-11 13:42 ` Kiyanovski, Arthur
2021-03-11 1:35 ` [RFC PATCH 06/10] netvsc: " Alexander Duyck
2021-03-11 1:35 ` [RFC PATCH 07/10] virtio_net: " Alexander Duyck
2021-03-11 1:36 ` [RFC PATCH 08/10] vmxnet3: " Alexander Duyck
2021-03-11 1:36 ` [RFC PATCH 09/10] bna: " Alexander Duyck
2021-03-11 1:36 ` [RFC PATCH 10/10] ionic: " Alexander Duyck
2021-03-11 17:19 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311123721.00005913@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=akiyano@amazon.com \
--cc=alexander.duyck@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=anthony.l.nguyen@intel.com \
--cc=doshir@vmware.com \
--cc=drivers@pensando.io \
--cc=gtzalik@amazon.com \
--cc=haiyangz@microsoft.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=mst@redhat.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pv-drivers@vmware.com \
--cc=rmody@marvell.com \
--cc=saeedb@amazon.com \
--cc=salil.mehta@huawei.com \
--cc=simon.horman@netronome.com \
--cc=skalluru@marvell.com \
--cc=snelson@pensando.io \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).