From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC9FC433DB for ; Tue, 16 Mar 2021 03:43:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9A31650B0 for ; Tue, 16 Mar 2021 03:43:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233668AbhCPDms (ORCPT ); Mon, 15 Mar 2021 23:42:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234911AbhCPDmX (ORCPT ); Mon, 15 Mar 2021 23:42:23 -0400 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59EBEC06174A for ; Mon, 15 Mar 2021 20:42:23 -0700 (PDT) Received: by mail-il1-x135.google.com with SMTP id b5so11402812ilq.10 for ; Mon, 15 Mar 2021 20:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GJXTGY660PRr+gnuulp4+I5fDAsuE0mVZ6I0ohXJicw=; b=zAsLbHuhdlOu5KU9tf3K1SgC76BOiciQU8aL6JiNurJf12fViKj8GaNqJI3dHZNLW3 EOjDVa1thkLQsvdBluva8crhFVynyirwCg+hIsdvgQRUpRSziE1kXummnh9R142I8jgy 0u+VoStOB1Pgw99FSJuxvvGkZY0qip9jBjA8z4NGbr9vEcznyaJA+WDeE735BT/FMXjT 76oVWaPaAl9OndST/OxHC9461ESDRFs+vJYg3j8mPc61dFbT31cHCx7lDoLjwrVubkIS 5PPYQ9VtvqtFpsEBceVI24h/G8I7QI9WyvcHGbfzLEv95MH6WWKUPAYYtfZvdD0/VqHu kumg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GJXTGY660PRr+gnuulp4+I5fDAsuE0mVZ6I0ohXJicw=; b=YvOb+gspCOT6+gIVCiJUeypiVsLlQhMizG3V/YmV6QDcrm/t89Nn1OHa43md0bOqcL Gz7m5qknrYjgCHLjIgSD1nsawSFLfEEG++4Gm6iw+559WBD0qkWN1ehjNpLSSqK4MaF9 6+F1GxCTr2E8B2AmOiCHlZgNrHO3x2v9HDgHQqw67T6NKHGZisPiz8P6Bxpq3miJjnjJ DFKGDJc9l2jkBTH2fxOEWAyLa/KHA1zkvHA7jRbALbETKPRZi194ozLVo4gjgHXrqY17 yiqMH086UhpqyJVid/PjxyfzOYpkxHFHgLFrFe0IFZc16bFhW33Y+1FMYEyzFRyFOyw5 6DrA== X-Gm-Message-State: AOAM530cY0GudEQ8gnS2pafFLI3iIevzqv372Wd8cO5FAGA8W9weyeVr LD8m3hUebCuCtyxzdI5LWiEc+gbsyFHRte0= X-Google-Smtp-Source: ABdhPJw4pPvqmyVw/yH3AtZEdnZ83L8E/Q2AQTVoYtUN+Q4v3ymg3b452NCoXpIobX8NcHb0YvSShg== X-Received: by 2002:a63:460e:: with SMTP id t14mr2014811pga.230.1615866132635; Mon, 15 Mar 2021 20:42:12 -0700 (PDT) Received: from work ([103.66.79.72]) by smtp.gmail.com with ESMTPSA id p20sm14460942pgb.62.2021.03.15.20.42.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Mar 2021 20:42:12 -0700 (PDT) Date: Tue, 16 Mar 2021 09:12:08 +0530 From: Manivannan Sadhasivam To: Alex Elder Cc: davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/3] net: ipa: fix another QMI message definition Message-ID: <20210316034208.GD29414@work> References: <20210315152112.1907968-1-elder@linaro.org> <20210315152112.1907968-3-elder@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315152112.1907968-3-elder@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 15, 2021 at 10:21:11AM -0500, Alex Elder wrote: > The ipa_init_modem_driver_req_ei[] encoding array for the > INIT_MODEM_DRIVER request message has some errors in it. > > First, the tlv_type associated with the hw_stats_quota_size field is > wrong; it duplicates the valiue used for the hw_stats_quota_base_addr > field (0x1f) and should use 0x20 instead. The tlv_type value for > the hw_stats_drop_size field also uses the same duplicate value; it > should use 0x22 instead. > > Second, there is no definition for the hw_stats_drop_base_addr > field. It is an optional 32-bit enumerated type value. > > Finally, the hw_stats_quota_base_addr, hw_stats_quota_size, and > hw_stats_drop_size fields are defined as enumerated types; they > should be unsigned 4-byte values. > > Reported-by: Manivannan Sadhasivam > Signed-off-by: Alex Elder Acked-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/net/ipa/ipa_qmi_msg.c | 34 +++++++++++++++++++++++++++------- > 1 file changed, 27 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ipa/ipa_qmi_msg.c b/drivers/net/ipa/ipa_qmi_msg.c > index e00f829a783f6..e4a6efbe9bd00 100644 > --- a/drivers/net/ipa/ipa_qmi_msg.c > +++ b/drivers/net/ipa/ipa_qmi_msg.c > @@ -530,7 +530,7 @@ struct qmi_elem_info ipa_init_modem_driver_req_ei[] = { > hw_stats_quota_base_addr_valid), > }, > { > - .data_type = QMI_SIGNED_4_BYTE_ENUM, > + .data_type = QMI_UNSIGNED_4_BYTE, > .elem_len = 1, > .elem_size = > sizeof_field(struct ipa_init_modem_driver_req, > @@ -545,37 +545,57 @@ struct qmi_elem_info ipa_init_modem_driver_req_ei[] = { > .elem_size = > sizeof_field(struct ipa_init_modem_driver_req, > hw_stats_quota_size_valid), > - .tlv_type = 0x1f, > + .tlv_type = 0x20, > .offset = offsetof(struct ipa_init_modem_driver_req, > hw_stats_quota_size_valid), > }, > { > - .data_type = QMI_SIGNED_4_BYTE_ENUM, > + .data_type = QMI_UNSIGNED_4_BYTE, > .elem_len = 1, > .elem_size = > sizeof_field(struct ipa_init_modem_driver_req, > hw_stats_quota_size), > - .tlv_type = 0x1f, > + .tlv_type = 0x20, > .offset = offsetof(struct ipa_init_modem_driver_req, > hw_stats_quota_size), > }, > + { > + .data_type = QMI_OPT_FLAG, > + .elem_len = 1, > + .elem_size = > + sizeof_field(struct ipa_init_modem_driver_req, > + hw_stats_drop_base_addr_valid), > + .tlv_type = 0x21, > + .offset = offsetof(struct ipa_init_modem_driver_req, > + hw_stats_drop_base_addr_valid), > + }, > + { > + .data_type = QMI_UNSIGNED_4_BYTE, > + .elem_len = 1, > + .elem_size = > + sizeof_field(struct ipa_init_modem_driver_req, > + hw_stats_drop_base_addr), > + .tlv_type = 0x21, > + .offset = offsetof(struct ipa_init_modem_driver_req, > + hw_stats_drop_base_addr), > + }, > { > .data_type = QMI_OPT_FLAG, > .elem_len = 1, > .elem_size = > sizeof_field(struct ipa_init_modem_driver_req, > hw_stats_drop_size_valid), > - .tlv_type = 0x1f, > + .tlv_type = 0x22, > .offset = offsetof(struct ipa_init_modem_driver_req, > hw_stats_drop_size_valid), > }, > { > - .data_type = QMI_SIGNED_4_BYTE_ENUM, > + .data_type = QMI_UNSIGNED_4_BYTE, > .elem_len = 1, > .elem_size = > sizeof_field(struct ipa_init_modem_driver_req, > hw_stats_drop_size), > - .tlv_type = 0x1f, > + .tlv_type = 0x22, > .offset = offsetof(struct ipa_init_modem_driver_req, > hw_stats_drop_size), > }, > -- > 2.27.0 >