From: Chen Yu <yu.c.chen@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org, sassmann@redhat.com,
kai.heng.feng@canonical.com, rjw@rjwysocki.net,
len.brown@intel.com, todd.e.brandt@intel.com,
sasha.neftin@intel.com, vitaly.lifshits@intel.com,
"yu.c.chen@intel.com Dvora Fuxbrumer"
<dvorax.fuxbrumer@linux.intel.com>
Subject: Re: [PATCH net-next 1/2] e1000e: Leverage direct_complete to speed up s2ram
Date: Tue, 16 Mar 2021 15:53:46 +0800 [thread overview]
Message-ID: <20210316075346.GA125266@chenyu-desktop> (raw)
In-Reply-To: <20210315140422.7a3d3bb2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hi Jakub,
thanks for taking a look!
On Mon, Mar 15, 2021 at 02:04:22PM -0700, Jakub Kicinski wrote:
> On Mon, 15 Mar 2021 12:02:30 -0700 Tony Nguyen wrote:
> > +static __maybe_unused int e1000e_pm_prepare(struct device *dev)
> > +{
> > + return pm_runtime_suspended(dev) &&
> > + pm_suspend_via_firmware();
>
> nit: I don't think you need to mark functions called by __maybe_unused
> as __maybe_unused, do you?
>
Not sure which function do you refer to having the __maybe_unused attribute
and invokes this e1000e_pm_prepare()?
I copied the definition from e1000e_pm_suspend() that if CONFIG_PM_SLEEP is not
set, we might get compile error of such PM hooks in this driver.
> The series LGTM although I don't know much about PM.
Thanks!
Best,
Chenyu
next prev parent reply other threads:[~2021-03-16 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 19:02 [PATCH net-next 0/2][pull request] 1GbE Intel Wired LAN Driver Updates 2021-03-15 Tony Nguyen
2021-03-15 19:02 ` [PATCH net-next 1/2] e1000e: Leverage direct_complete to speed up s2ram Tony Nguyen
2021-03-15 21:04 ` Jakub Kicinski
2021-03-16 7:53 ` Chen Yu [this message]
2021-03-15 19:02 ` [PATCH net-next 2/2] e1000e: Remove the runtime suspend restriction on CNP+ Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316075346.GA125266@chenyu-desktop \
--to=yu.c.chen@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dvorax.fuxbrumer@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kuba@kernel.org \
--cc=len.brown@intel.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sasha.neftin@intel.com \
--cc=sassmann@redhat.com \
--cc=todd.e.brandt@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox