From: Vladimir Oltean <olteanv@gmail.com>
To: Po Liu <po.liu@nxp.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next] net: add a helper to avoid issues with HW TX timestamping and SO_TXTIME
Date: Tue, 16 Mar 2021 12:19:01 +0200 [thread overview]
Message-ID: <20210316101901.gkcdczquxrtwpydh@skbuf> (raw)
In-Reply-To: <DBBPR04MB781851A0F0CD632E2E1AE1A292909@DBBPR04MB7818.eurprd04.prod.outlook.com>
Hi Po,
On Thu, Mar 11, 2021 at 02:30:12AM +0000, Po Liu wrote:
> Hi
>
> Can it just move
>
> skb->tstamp = ktime_set(0, 0);
>
> into
>
> skb_tstamp_tx(skb, &shhwtstamps);
>
> if it always need to clear for HW tstamp setting.
I don't know if that works under all circumstances. Also, to keep the
driver interface consistent, we would also need to plug that into
skb_complete_tx_timestamp, for the case when the driver is working with
a clone directly.
It just seemed simpler to me to modify the few drivers which use SO_TXTIME.
next prev parent reply other threads:[~2021-03-16 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 2:30 [PATCH net-next] net: add a helper to avoid issues with HW TX timestamping and SO_TXTIME Po Liu
2021-03-16 10:19 ` Vladimir Oltean [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-10 14:50 Vladimir Oltean
2021-03-10 15:16 ` Richard Cochran
2021-03-10 15:21 ` Vladimir Oltean
2021-03-10 19:52 ` Vinicius Costa Gomes
2021-03-10 21:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316101901.gkcdczquxrtwpydh@skbuf \
--to=olteanv@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=richardcochran@gmail.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox