From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91B08C433DB for ; Wed, 17 Mar 2021 01:01:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68A3564F97 for ; Wed, 17 Mar 2021 01:01:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232858AbhCQBBM (ORCPT ); Tue, 16 Mar 2021 21:01:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:40782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232387AbhCQA7a (ORCPT ); Tue, 16 Mar 2021 20:59:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4D2E464F9C; Wed, 17 Mar 2021 00:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615942770; bh=ideE3VkGpIYHkuOvbwSnSvB/LfLCelCcufnWZ58AuO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l5gXTrNxYkckukKu6qUk1CS/ABdVL5JkeL1WICXj4BE+M/gKQxxQ6aJEt8Ki7pxbG pq17+MOXgqNRd30Toa/ULdJNDck/lH43sE/n269n+kYmbbIX2+hFxXImB4AU703l7t /VD9DEv4Qstw3NYtSS24Yqt75PgHZFweq3Oxms6tiIezXgEyY6MOQ0DMX/IbqDjti1 0+4PQwQIAJOdT/wlxNcFQ2hPfbNFl8BN9ieATfdW+TQQN/o5LAIXyfKQzSBFjXEmwH IeJMgMFOfa3DaSbdITtuYGP2jzg6NukZhWS+3MlUwpEBmA9ZPv9a4FvYt7LKLS7MFu g5+q043Zr3lKQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia-Ju Bai , TOTE Robot , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 07/21] net: tehuti: fix error return code in bdx_probe() Date: Tue, 16 Mar 2021 20:59:06 -0400 Message-Id: <20210317005920.726931-7-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210317005920.726931-1-sashal@kernel.org> References: <20210317005920.726931-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jia-Ju Bai [ Upstream commit 38c26ff3048af50eee3fcd591921357ee5bfd9ee ] When bdx_read_mac() fails, no error return code of bdx_probe() is assigned. To fix this bug, err is assigned with -EFAULT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/tehuti/tehuti.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/tehuti/tehuti.c b/drivers/net/ethernet/tehuti/tehuti.c index 163d8d16bc24..75620c3365b3 100644 --- a/drivers/net/ethernet/tehuti/tehuti.c +++ b/drivers/net/ethernet/tehuti/tehuti.c @@ -2058,6 +2058,7 @@ bdx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /*bdx_hw_reset(priv); */ if (bdx_read_mac(priv)) { pr_err("load MAC address failed\n"); + err = -EFAULT; goto err_out_iomap; } SET_NETDEV_DEV(ndev, &pdev->dev); -- 2.30.1