From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 326A0C432C3 for ; Wed, 17 Mar 2021 01:03:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05A4864FAB for ; Wed, 17 Mar 2021 01:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232750AbhCQBDH (ORCPT ); Tue, 16 Mar 2021 21:03:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:41594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231730AbhCQBAS (ORCPT ); Tue, 16 Mar 2021 21:00:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EE54B65018; Wed, 17 Mar 2021 01:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615942815; bh=6MbzyU9GObKJwUVNcrbuVtXcHk0CIpvCUAPQlbRkRwQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dycHkxu7fJizlf5wMahZ23XIoUP0OYtggPXOp2tVUeLZnYHjpq+NGZGlZ+iP1duR6 ItL3GVa2a+W8HI3HrhmCFoJiIA5iGzyTXxR+N3R16Tx4cg+wLSQbGm0zPMacPM9+QI l6kqYusRtvaLC0I8M4MctLkCzq7S2fPDmcRc8ZltwXsYBveQcNRI6BXQfll84gRftt ULl2ik6j0fowTbfloLcmd+wz2DOoJhUqJN7w8SkgeN/Ytk6rUxyQlfCxZBvKs3ahAR 0UOIc/qJyTdLgV/Kwq4eYaaq3+hYC4J04alJKVdMYsTkveqZq4lGEt7pE03jm38CJk cFN1g+DHmSRJg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia-Ju Bai , TOTE Robot , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 05/14] net: tehuti: fix error return code in bdx_probe() Date: Tue, 16 Mar 2021 20:59:59 -0400 Message-Id: <20210317010008.727496-5-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210317010008.727496-1-sashal@kernel.org> References: <20210317010008.727496-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jia-Ju Bai [ Upstream commit 38c26ff3048af50eee3fcd591921357ee5bfd9ee ] When bdx_read_mac() fails, no error return code of bdx_probe() is assigned. To fix this bug, err is assigned with -EFAULT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/tehuti/tehuti.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/tehuti/tehuti.c b/drivers/net/ethernet/tehuti/tehuti.c index 14c9d1baa85c..19c832aaecf0 100644 --- a/drivers/net/ethernet/tehuti/tehuti.c +++ b/drivers/net/ethernet/tehuti/tehuti.c @@ -2068,6 +2068,7 @@ bdx_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /*bdx_hw_reset(priv); */ if (bdx_read_mac(priv)) { pr_err("load MAC address failed\n"); + err = -EFAULT; goto err_out_iomap; } SET_NETDEV_DEV(ndev, &pdev->dev); -- 2.30.1