From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
oss-drivers@netronome.com, simon.horman@netronome.com,
yisen.zhuang@huawei.com, salil.mehta@huawei.com,
intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
drivers@pensando.io, snelson@pensando.io, netanel@amazon.com,
akiyano@amazon.com, gtzalik@amazon.com, saeedb@amazon.com,
GR-Linux-NIC-Dev@marvell.com, skalluru@marvell.com,
rmody@marvell.com, kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, mst@redhat.com,
jasowang@redhat.com, pv-drivers@vmware.com, doshir@vmware.com,
alexanderduyck@fb.com, Kernel-team@fb.com
Subject: Re: [net-next PATCH v2 00/10] ethtool: Factor out common code related to writing ethtool strings
Date: Wed, 17 Mar 2021 09:41:37 -0700 [thread overview]
Message-ID: <20210317094137.00007073@intel.com> (raw)
In-Reply-To: <161594093708.5644.11391417312031401152.stgit@localhost.localdomain>
Alexander Duyck wrote:
> This patch set is meant to be a cleanup and refactoring of common code bits
> from several drivers. Specificlly a number of drivers engage in a pattern
> where they will use some variant on an sprintf or memcpy to write a string
> into the ethtool string array and then they will increment their pointer by
> ETH_GSTRING_LEN.
>
> Instead of having each driver implement this independently I am refactoring
> the code so that we have one central function, ethtool_sprintf that does
> all this and takes a double pointer to access the data, a formatted string
> to print, and the variable arguments that are associated with the string.
>
> Changes from v1:
> Fixed usage of char ** vs unsigned char ** in hisilicon drivers
>
> Changes from RFC:
> Renamed ethtool_gsprintf to ethtool_sprintf
> Fixed reverse xmas tree issue in patch 2
>
Thanks Alex, I had a look over the whole thing and it looks good to me.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2021-03-17 16:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 0:30 [net-next PATCH v2 00/10] ethtool: Factor out common code related to writing ethtool strings Alexander Duyck
2021-03-17 0:30 ` [net-next PATCH v2 01/10] ethtool: Add common function for filling out strings Alexander Duyck
2021-03-17 0:30 ` [net-next PATCH v2 02/10] intel: Update drivers to use ethtool_sprintf Alexander Duyck
2021-03-17 16:36 ` Jesse Brandeburg
2021-03-17 0:30 ` [net-next PATCH v2 03/10] nfp: Replace nfp_pr_et with ethtool_sprintf Alexander Duyck
2021-03-17 0:31 ` [net-next PATCH v2 04/10] hisilicon: Update drivers to use ethtool_sprintf Alexander Duyck
2021-03-17 0:31 ` [net-next PATCH v2 05/10] ena: Update driver " Alexander Duyck
2021-03-17 0:31 ` [net-next PATCH v2 06/10] netvsc: " Alexander Duyck
2021-03-17 0:31 ` [net-next PATCH v2 07/10] virtio_net: " Alexander Duyck
2021-03-17 0:31 ` [net-next PATCH v2 08/10] vmxnet3: " Alexander Duyck
2021-03-17 0:31 ` [net-next PATCH v2 09/10] bna: " Alexander Duyck
2021-03-17 0:31 ` [net-next PATCH v2 10/10] ionic: " Alexander Duyck
2021-03-17 16:41 ` Jesse Brandeburg [this message]
2021-03-17 18:50 ` [net-next PATCH v2 00/10] ethtool: Factor out common code related to writing ethtool strings patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317094137.00007073@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=Kernel-team@fb.com \
--cc=akiyano@amazon.com \
--cc=alexander.duyck@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=doshir@vmware.com \
--cc=drivers@pensando.io \
--cc=gtzalik@amazon.com \
--cc=haiyangz@microsoft.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=mst@redhat.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pv-drivers@vmware.com \
--cc=rmody@marvell.com \
--cc=saeedb@amazon.com \
--cc=salil.mehta@huawei.com \
--cc=simon.horman@netronome.com \
--cc=skalluru@marvell.com \
--cc=snelson@pensando.io \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).