netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: netdev@vger.kernel.org, pavana.sharma@digi.com,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	olteanv@gmail.com, andrew@lunn.ch, ashkan.boldaji@digi.com,
	davem@davemloft.net, kuba@kernel.org
Cc: f.fainelli@gmail.com, vivien.didelot@gmail.com, lkp@intel.com,
	"Marek Behún" <kabel@kernel.org>
Subject: [PATCH net-next v17 0/4] Add support for mv88e6393x family of Marvell
Date: Wed, 17 Mar 2021 14:46:39 +0100	[thread overview]
Message-ID: <20210317134643.24463-1-kabel@kernel.org> (raw)

Hello,

after 2 months I finally had time to send v17 of Amethyst patches.

This series is tested on Marvell CN9130-CRB.

Changes since v16:
- dropped patches adding 5gbase-r, since they are already merged
- rebased onto net-next/master
- driver API renamed set_egress_flood() method into 2 methods for
  ucast/mcast floods, so this is fixed

Changes from v15:
- put 10000baseKR_Full back into phylink_validate method for Amethyst,
  it seems I misunderstood the meaning behind things and removed it
  from v15
- removed erratum 3.7, since the procedure is done anyway in
  mv88e6390_serdes_pcs_config
- renumbered errata 3.6 and 3.8 to 4.6 and 4.8, according to newer
  version of the errata document
- refactored errata code a little and removed duplicate macro
  definitions (for example MV88E6390_SGMII_CONTROL is already called
  MV88E6390_SGMII_BMCR)

Changes from v14:
- added my Signed-off-by tags to Pavana's patches, since I am sending
  them (as suggested by Andrew)
- added documentation to second patch adding 5gbase-r mode (as requested
  by Russell)
- added Reviewed-by tags
- applied Vladimir's suggestions:
  - reduced indentation level in mv88e6xxx_set_egress_port and
    mv88e6393x_serdes_port_config
  - removed 10000baseKR_Full from mv88e6393x_phylink_validate
  - removed PHY_INTERFACE_MODE_10GKR from mv88e6xxx_port_set_cmode

Changes from v13:
- added patch that wraps .set_egress_port into mv88e6xxx_set_egress_port,
  so that we do not have to set chip->*gress_dest_port members in every
  implementation of this method
- for the patch that adds Amethyst support:
  - added more information into commit message
  - added these methods for mv88e6393x_ops:
      .port_sync_link
      .port_setup_message_port
      .port_max_speed_mode (new implementation needed)
      .atu_get_hash
      .atu_set_hash
      .serdes_pcs_config
      .serdes_pcs_an_restart
      .serdes_pcs_link_up
  - this device can set upstream port per port, so implement
      .port_set_upstream_port
    instead of
      .set_cpu_port
  - removed USXGMII cmode (not yet supported, working on it)
  - added debug messages into mv88e6393x_port_set_speed_duplex
  - added Amethyst errata 4.5 (EEE should be disabled on SERDES ports)
  - fixed 5gbase-r serdes configuration and interrupt handling
  - refactored mv88e6393x_serdes_setup_errata
  - refactored mv88e6393x_port_policy_write
- added patch implementing .port_set_policy for Amethyst

Marek

Marek Behún (2):
  net: dsa: mv88e6xxx: wrap .set_egress_port method
  net: dsa: mv88e6xxx: implement .port_set_policy for Amethyst

Pavana Sharma (2):
  net: dsa: mv88e6xxx: change serdes lane parameter type from u8 type to
    int
  net: dsa: mv88e6xxx: add support for mv88e6393x family

 drivers/net/dsa/mv88e6xxx/chip.c    | 233 +++++++++++++---
 drivers/net/dsa/mv88e6xxx/chip.h    |  20 +-
 drivers/net/dsa/mv88e6xxx/global1.c |  19 +-
 drivers/net/dsa/mv88e6xxx/global1.h |   2 +
 drivers/net/dsa/mv88e6xxx/global2.h |   8 +
 drivers/net/dsa/mv88e6xxx/port.c    | 397 +++++++++++++++++++++++++---
 drivers/net/dsa/mv88e6xxx/port.h    |  48 ++++
 drivers/net/dsa/mv88e6xxx/serdes.c  | 338 ++++++++++++++++++++---
 drivers/net/dsa/mv88e6xxx/serdes.h  |  98 ++++---
 9 files changed, 1002 insertions(+), 161 deletions(-)

-- 
2.26.2


             reply	other threads:[~2021-03-17 13:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 13:46 Marek Behún [this message]
2021-03-17 13:46 ` [PATCH net-next v17 1/4] net: dsa: mv88e6xxx: change serdes lane parameter type from u8 type to int Marek Behún
2021-03-17 13:46 ` [PATCH net-next v17 2/4] net: dsa: mv88e6xxx: wrap .set_egress_port method Marek Behún
2021-03-17 14:22   ` Vladimir Oltean
2021-03-17 14:34     ` Marek Behún
2021-03-17 14:40       ` Vladimir Oltean
2021-03-17 13:46 ` [PATCH net-next v17 3/4] net: dsa: mv88e6xxx: add support for mv88e6393x family Marek Behún
2021-03-17 13:46 ` [PATCH net-next v17 4/4] net: dsa: mv88e6xxx: implement .port_set_policy for Amethyst Marek Behún
2021-03-17 14:32   ` Vladimir Oltean
2021-03-17 21:50 ` [PATCH net-next v17 0/4] Add support for mv88e6393x family of Marvell patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210317134643.24463-1-kabel@kernel.org \
    --to=kabel@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=ashkan.boldaji@digi.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pavana.sharma@digi.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).