From: Kurt Kanzenbach <kurt@linutronix.de>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
netdev@vger.kernel.org, Kurt Kanzenbach <kurt@linutronix.de>
Subject: [PATCH net-next 0/1] taprio: Handle short intervals and large packets
Date: Thu, 18 Mar 2021 08:34:54 +0100 [thread overview]
Message-ID: <20210318073455.17281-1-kurt@linutronix.de> (raw)
Hi,
there is a problem with the software implementation of TAPRIO and TCP
communication. When using short intervals e.g. below one millisecond, large
packets won't be transmitted. That's because the software implementation takes
the packet length and calculates the transmission time. If the transmission time
is larger than the configured interval, no packet will be transmitted. Fix that
by segmenting the skb for the software implementation.
Tested with software only and full hardware offloading applied using iperf3.
Vinicius, do you mind testing as well?
Changes since RFC:
* Move segmentation, so that timestamps for tx assisted mode are
calculated for the segments
* Skip it for the full hardware offloading case
Previous versions:
* https://lkml.kernel.org/netdev/20210312092823.1429-1-kurt@linutronix.de/
Kurt Kanzenbach (1):
taprio: Handle short intervals and large packets
net/sched/sch_taprio.c | 64 +++++++++++++++++++++++++++++++++++-------
1 file changed, 54 insertions(+), 10 deletions(-)
--
2.20.1
next reply other threads:[~2021-03-18 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 7:34 Kurt Kanzenbach [this message]
2021-03-18 7:34 ` [PATCH net-next 1/1] taprio: Handle short intervals and large packets Kurt Kanzenbach
2021-03-19 19:10 ` [PATCH net-next 0/1] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318073455.17281-1-kurt@linutronix.de \
--to=kurt@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).