From: Antoine Tenart <atenart@kernel.org>
To: davem@davemloft.net, kuba@kernel.org, alexander.duyck@gmail.com
Cc: Antoine Tenart <atenart@kernel.org>, netdev@vger.kernel.org
Subject: [PATCH net-next v4 13/13] net: NULL the old xps map entries when freeing them
Date: Thu, 18 Mar 2021 19:37:52 +0100 [thread overview]
Message-ID: <20210318183752.2612563-14-atenart@kernel.org> (raw)
In-Reply-To: <20210318183752.2612563-1-atenart@kernel.org>
In __netif_set_xps_queue, old map entries from the old dev_maps are
freed but their corresponding entry in the old dev_maps aren't NULLed.
Fix this.
Signed-off-by: Antoine Tenart <atenart@kernel.org>
---
net/core/dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index d5f6ba209f1e..4961fc2e9b19 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2764,6 +2764,7 @@ int __netif_set_xps_queue(struct net_device *dev, const unsigned long *mask,
continue;
}
+ RCU_INIT_POINTER(dev_maps->attr_map[tci], NULL);
kfree_rcu(map, rcu);
}
}
--
2.30.2
next prev parent reply other threads:[~2021-03-18 18:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 18:37 [PATCH net-next v4 00/13] net: xps: improve the xps maps handling Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 01/13] net-sysfs: convert xps_cpus_show to bitmap_zalloc Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 02/13] net-sysfs: store the return of get_netdev_queue_index in an unsigned int Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 03/13] net-sysfs: make xps_cpus_show and xps_rxqs_show consistent Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 04/13] net: embed num_tc in the xps maps Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 05/13] net: embed nr_ids " Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 06/13] net: remove the xps possible_mask Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 07/13] net: move the xps maps to an array Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 08/13] net: add an helper to copy xps maps to the new dev_maps Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 09/13] net: improve queue removal readability in __netif_set_xps_queue Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 10/13] net-sysfs: move the rtnl unlock up in the xps show helpers Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 11/13] net-sysfs: move the xps cpus/rxqs retrieval in a common function Antoine Tenart
2021-03-18 18:37 ` [PATCH net-next v4 12/13] net: fix use after free in xps Antoine Tenart
2021-03-18 18:37 ` Antoine Tenart [this message]
2021-03-18 23:10 ` [PATCH net-next v4 00/13] net: xps: improve the xps maps handling patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318183752.2612563-14-atenart@kernel.org \
--to=atenart@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).