From: Matthew Wilcox <willy@infradead.org>
To: William Kucharski <william.kucharski@oracle.com>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] net/rds: correct socket tunable error in rds_tcp_tune()
Date: Fri, 19 Mar 2021 16:48:23 +0000 [thread overview]
Message-ID: <20210319164823.GA1124392@casper.infradead.org> (raw)
In-Reply-To: <20210317145204.7282-1-william.kucharski@oracle.com>
On Wed, Mar 17, 2021 at 08:52:04AM -0600, William Kucharski wrote:
> Correct an error where setting /proc/sys/net/rds/tcp/rds_tcp_rcvbuf would
> instead modify the socket's sk_sndbuf and would leave sk_rcvbuf untouched.
>
> Signed-off-by: William Kucharski <william.kucharski@oracle.com>
Looks like a pretty clear copy-n-paste error. I think Coverity have
started looking for issues like this?
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Also, maybe,
Fixes: c6a58ffed536 ("RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket")
prev parent reply other threads:[~2021-03-19 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 14:52 [PATCH] net/rds: correct socket tunable error in rds_tcp_tune() William Kucharski
2021-03-17 17:18 ` Santosh Shilimkar
2021-03-19 16:48 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319164823.GA1124392@casper.infradead.org \
--to=willy@infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).