* [PATCH] net/rds: correct socket tunable error in rds_tcp_tune()
@ 2021-03-17 14:52 William Kucharski
2021-03-17 17:18 ` Santosh Shilimkar
2021-03-19 16:48 ` Matthew Wilcox
0 siblings, 2 replies; 3+ messages in thread
From: William Kucharski @ 2021-03-17 14:52 UTC (permalink / raw)
To: netdev, linux-rdma, rds-devel, linux-kernel
Cc: Santosh Shilimkar, David S . Miller, Jakub Kicinski
Correct an error where setting /proc/sys/net/rds/tcp/rds_tcp_rcvbuf would
instead modify the socket's sk_sndbuf and would leave sk_rcvbuf untouched.
Signed-off-by: William Kucharski <william.kucharski@oracle.com>
---
net/rds/tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/tcp.c b/net/rds/tcp.c
index 43db0eca911f..130e5988f956 100644
--- a/net/rds/tcp.c
+++ b/net/rds/tcp.c
@@ -500,7 +500,7 @@ void rds_tcp_tune(struct socket *sock)
sk->sk_userlocks |= SOCK_SNDBUF_LOCK;
}
if (rtn->rcvbuf_size > 0) {
- sk->sk_sndbuf = rtn->rcvbuf_size;
+ sk->sk_rcvbuf = rtn->rcvbuf_size;
sk->sk_userlocks |= SOCK_RCVBUF_LOCK;
}
release_sock(sk);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net/rds: correct socket tunable error in rds_tcp_tune()
2021-03-17 14:52 [PATCH] net/rds: correct socket tunable error in rds_tcp_tune() William Kucharski
@ 2021-03-17 17:18 ` Santosh Shilimkar
2021-03-19 16:48 ` Matthew Wilcox
1 sibling, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2021-03-17 17:18 UTC (permalink / raw)
To: William Kucharski
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
(Previous reply bounced due to format so re-sending to the list for archives)
On Mar 17, 2021, at 7:52 AM, William Kucharski <william.kucharski@oracle.com> wrote:
>
> Correct an error where setting /proc/sys/net/rds/tcp/rds_tcp_rcvbuf would
> instead modify the socket's sk_sndbuf and would leave sk_rcvbuf untouched.
>
> Signed-off-by: William Kucharski <william.kucharski@oracle.com>
> —
Looks good. Thanks !!
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/rds: correct socket tunable error in rds_tcp_tune()
2021-03-17 14:52 [PATCH] net/rds: correct socket tunable error in rds_tcp_tune() William Kucharski
2021-03-17 17:18 ` Santosh Shilimkar
@ 2021-03-19 16:48 ` Matthew Wilcox
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2021-03-19 16:48 UTC (permalink / raw)
To: William Kucharski
Cc: netdev, linux-rdma, rds-devel, linux-kernel, Santosh Shilimkar,
David S . Miller, Jakub Kicinski
On Wed, Mar 17, 2021 at 08:52:04AM -0600, William Kucharski wrote:
> Correct an error where setting /proc/sys/net/rds/tcp/rds_tcp_rcvbuf would
> instead modify the socket's sk_sndbuf and would leave sk_rcvbuf untouched.
>
> Signed-off-by: William Kucharski <william.kucharski@oracle.com>
Looks like a pretty clear copy-n-paste error. I think Coverity have
started looking for issues like this?
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Also, maybe,
Fixes: c6a58ffed536 ("RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket")
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-19 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-17 14:52 [PATCH] net/rds: correct socket tunable error in rds_tcp_tune() William Kucharski
2021-03-17 17:18 ` Santosh Shilimkar
2021-03-19 16:48 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).