From: Vladimir Oltean <olteanv@gmail.com>
To: Pavel Machek <pavel@denx.de>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Re: enetc: fix bitfields, we are clearing wrong bits
Date: Sun, 21 Mar 2021 19:49:14 +0200 [thread overview]
Message-ID: <20210321174914.q7qanecg5s6dvoz6@skbuf> (raw)
In-Reply-To: <20210321174419.jiwfu2nsfyhlhllc@skbuf>
On Sun, Mar 21, 2021 at 07:44:19PM +0200, Vladimir Oltean wrote:
> On Sun, Mar 21, 2021 at 05:25:00PM +0100, Pavel Machek wrote:
> > Bitfield manipulation in enetc_mac_config() looks wrong. Fix
> > it. Untested.
> >
> > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
> >
> > diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> > index 224fc37a6757..b85079493933 100644
> > --- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> > +++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c
> > @@ -505,7 +505,7 @@ static void enetc_mac_config(struct enetc_hw *hw, phy_interface_t phy_mode)
> > if (phy_interface_mode_is_rgmii(phy_mode)) {
> > val = enetc_port_rd(hw, ENETC_PM0_IF_MODE);
> > val &= ~ENETC_PM0_IFM_EN_AUTO;
> > - val &= ENETC_PM0_IFM_IFMODE_MASK;
> > + val &= ~ENETC_PM0_IFM_IFMODE_MASK;
> > val |= ENETC_PM0_IFM_IFMODE_GMII | ENETC_PM0_IFM_RG;
> > enetc_port_wr(hw, ENETC_PM0_IF_MODE, val);
> > }
> >
> > --
> > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>
> Fixes: c76a97218dcb ("net: enetc: force the RGMII speed and duplex instead of operating in inband mode")
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> Note that for normal operation, the bug was inconsequential, due to the
> fact that we write the IF_MODE register in two stages, first in
> .phylink_mac_config (which incorrectly cleared out a bunch of stuff),
> then we update the speed and duplex to the correct values in
> .phylink_mac_link_up. Maybe loopback mode was broken.
>
> Thanks!
I forgot to mention, target tree should be "net" and patch should be
queued up for stable.
prev parent reply other threads:[~2021-03-21 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 16:25 enetc: fix bitfields, we are clearing wrong bits Pavel Machek
2021-03-21 17:44 ` Vladimir Oltean
2021-03-21 17:49 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210321174914.q7qanecg5s6dvoz6@skbuf \
--to=olteanv@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox