From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 793DEC433C1 for ; Thu, 25 Mar 2021 10:10:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A36661A2B for ; Thu, 25 Mar 2021 10:10:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230119AbhCYKJl (ORCPT ); Thu, 25 Mar 2021 06:09:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60413 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230158AbhCYKJU (ORCPT ); Thu, 25 Mar 2021 06:09:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616666959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kHwyM01WyqgWKCfJirzSlimPQ/XDp3q0BkoluHcHB6k=; b=OZlZqvDSASd+2XrkeMQs1YXRFqryjJKYedeQkbAhTi6YZh/wdRetle2swy5EuhIQ0VV0KF kdyPh7wYeDnGUzo+Taessuj/U30o27HE8ZSQqbGWxypqeSnfmyKsYb/0LS9ztK8tKjA5/A e0rPUU/vATfuTCPnEgEe8NAn+dZREuk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-Sha--7I-NYCDm9HaEDHf1A-1; Thu, 25 Mar 2021 06:09:17 -0400 X-MC-Unique: Sha--7I-NYCDm9HaEDHf1A-1 Received: by mail-wm1-f70.google.com with SMTP id r65-20020a1c2b440000b029010f4ee06223so750022wmr.1 for ; Thu, 25 Mar 2021 03:09:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kHwyM01WyqgWKCfJirzSlimPQ/XDp3q0BkoluHcHB6k=; b=DrLaEqVIz5I4zXlfLEaV/n7H4SvrmaPJMmtVWB/fclOASkA4CHOE0GITa9J81hGwNK 72OisdAjGM2YIGvyjsm8VP9CU8VuTufxrAZKukor+gUMl1fGFI5iEYjv9NDErpSG+ccl psywKEKckgpZGtLN7ZV2koFh1DKI/rlC4GCGjZjJ55t8gTvWhde++sdSr4Mrwr2EqOdd 1L1b8dHfNMPjCc27QKXI6st6V7nIznpyM6camHgUfsgdz7aKvHrK5NpUwymD9B69VotW FmMOUoPnprxyttJykvxlBZXe4wCtLtHubIfG9HDig9HBO6gKIGxhEOeJxOt9FvwJ7V7Z /xYw== X-Gm-Message-State: AOAM532T3EUS94Lywua3vX0RtwSTAHx+F5cWbhpYkZX1SOCXfS59fZkr uzVaQwQhM7565bMP22JCNfeG8JeQrMnK9kDtpK1+2kT8zpkdExO11NIYikom99N8Ms+TH6paxuN ByYJJ3JNk9IEJKQiZ X-Received: by 2002:adf:a18a:: with SMTP id u10mr8019010wru.197.1616666956447; Thu, 25 Mar 2021 03:09:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzyIyWOSmU8uyQs1/B6aVWJTTtn53k7n4EHV1c4wLdktCa9Xv2dMFQu8Wdv5ezJuNgAsU+aw== X-Received: by 2002:adf:a18a:: with SMTP id u10mr8018978wru.197.1616666956222; Thu, 25 Mar 2021 03:09:16 -0700 (PDT) Received: from steredhat (host-79-34-249-199.business.telecomitalia.it. [79.34.249.199]) by smtp.gmail.com with ESMTPSA id s83sm6216998wms.16.2021.03.25.03.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 03:09:15 -0700 (PDT) Date: Thu, 25 Mar 2021 11:09:13 +0100 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Andra Paraschiv , Norbert Slusarek , Colin Ian King , Alexander Popov , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stsp2@yandex.ru, oxffffaa@gmail.com Subject: Re: [RFC PATCH v7 13/22] virtio/vsock: add SEQPACKET receive logic Message-ID: <20210325100913.7rewuc4wn7zwtrqf@steredhat> References: <20210323130716.2459195-1-arseny.krasnov@kaspersky.com> <20210323131316.2461284-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210323131316.2461284-1-arseny.krasnov@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 23, 2021 at 04:13:13PM +0300, Arseny Krasnov wrote: >This modifies current receive logic for SEQPACKET support: >1) Inserts 'SEQ_BEGIN' packet to socket's rx queue. >2) Inserts 'RW' packet to socket's rx queue, but without merging with > buffer of last packet in queue. >3) Performs check for packet and socket types on receive(if mismatch, > then reset connection). > >Signed-off-by: Arseny Krasnov >--- > v6 -> v7: > In 'virtio_transport_recv_pkt()', 'sock_put()' is added, when type of > received packet does not match to the type of socket. > > net/vmw_vsock/virtio_transport_common.c | 64 +++++++++++++++++-------- > 1 file changed, 45 insertions(+), 19 deletions(-) Reviewed-by: Stefano Garzarella