Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

Jason Gunthorpe
2021-03-30T19:48:22Z

On Tue, Mar 30, 2021 at 10:00:19AM -0500, Bjorn Helgaas wrote:
> On Tue, Mar 30, 2021 at 10:57:38AM -0300, Jason Gunthorpe wrote:
> > On Mon, Mar 29, 2021 at 08:29:49PM -0500, Bjorn Helgaas wrote:
> >
> > > I think I misunderstood Greg's subdirectory comment. We already have
> > > directories like this:
> >
> > Yes, IIRC, Greg's remark applies if you have to start creating
> > directories with manual kobjects.
> >
> > > and aspm_ctrl_attr_group (for "link") is nicely done with static
> > > attributes. So I think we could do something like this:
> > >
> > > /sys/bus/pci/devices/0000:01:00.0/ # PF directory
> > > sriov/ # SR-IOV related stuff
> > > vf_total_msix
> > > vf_msix_count_BB:DD.F # includes bus/dev/fn of first VF
> > > ...
> > > vf_msix_count_BB:DD.F # includes bus/dev/fn of last VF
> >
> > It looks a bit odd that it isn't a subdirectory, but this seems
> > reasonable.
>
> Sorry, I missed your point; you'll have to lay it out more explicitly.
> I did intend that "sriov" *is* a subdirectory of the 0000:01:00.0
> directory. The full paths would be:
>
> /sys/bus/pci/devices/0000:01:00.0/sriov/vf_total_msix
> /sys/bus/pci/devices/0000:01:00.0/sriov/vf_msix_count_BB:DD.F
> ...

Sorry, I was meaning what you first proposed:

/sys/bus/pci/devices/0000:01:00.0/sriov/BB:DD.F/vf_msix_count

Which has the extra sub directory to organize the child VFs.

Keep in mind there is going to be alot of VFs here, > 1k - so this
will be a huge directory.

Jason