From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82C98C433DB for ; Fri, 26 Mar 2021 22:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A21061A28 for ; Fri, 26 Mar 2021 22:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbhCZW3g (ORCPT ); Fri, 26 Mar 2021 18:29:36 -0400 Received: from mga07.intel.com ([134.134.136.100]:17154 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbhCZW31 (ORCPT ); Fri, 26 Mar 2021 18:29:27 -0400 IronPort-SDR: MQ6T62D61cvBdDNKSSEUTf6EZjd9gKE2GQuS2pRBXGo+cAY3gJq6o2du/dr7PRNBVyyY33J0+i x8YjjrjLbebg== X-IronPort-AV: E=McAfee;i="6000,8403,9935"; a="255224184" X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="255224184" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 15:29:27 -0700 IronPort-SDR: 5LgOp+Q/ERlPIkGYWYvXy2yds88VI0rUvw09LKQszrzaIn503FOS5LpwdI4JQzUBdzwb+Pq802 dq00br/lFYRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="443965441" Received: from lkp-server01.sh.intel.com (HELO 69d8fcc516b7) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 26 Mar 2021 15:29:24 -0700 Received: from kbuild by 69d8fcc516b7 with local (Exim 4.92) (envelope-from ) id 1lPuxI-00034d-9C; Fri, 26 Mar 2021 22:29:24 +0000 Date: Sat, 27 Mar 2021 06:29:15 +0800 From: kernel test robot To: Gregory Greenman Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Luca Coelho , Kalle Valo , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] iwlwifi: mvm: fix memdup.cocci warnings Message-ID: <20210326222915.GA61209@88c1b4e57a79> References: <202103270644.54GAfxLU-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202103270644.54GAfxLU-lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: kernel test robot drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:110:8-15: WARNING opportunity for kmemdup Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support") CC: Gregory Greenman Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0f4498cef9f5cd18d7c6639a2a902ec1edc5be4e commit: 21254908cbe995a3982a23da32c30d1b43467043 iwlwifi: mvm: add RFI-M support rfi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c @@ -107,12 +107,10 @@ struct iwl_rfi_freq_table_resp_cmd *iwl_ if (WARN_ON_ONCE(iwl_rx_packet_payload_len(cmd.resp_pkt) != resp_size)) return ERR_PTR(-EIO); - resp = kzalloc(resp_size, GFP_KERNEL); + resp = kmemdup(cmd.resp_pkt->data, resp_size, GFP_KERNEL); if (!resp) return ERR_PTR(-ENOMEM); - memcpy(resp, cmd.resp_pkt->data, resp_size); - iwl_free_resp(&cmd); return resp; }