From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Chan <michael.chan@broadcom.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-rdma@vger.kernel.org,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Netdev <netdev@vger.kernel.org>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: [PATCH rdma-next v1 5/5] net/bnxt: Use direct API instead of useless indirection
Date: Mon, 29 Mar 2021 11:16:25 -0300 [thread overview]
Message-ID: <20210329141625.GA2356281@nvidia.com> (raw)
In-Reply-To: <CACKFLinM5w4Go25et=W7ABi3F9CVuyv=A_eXkOOHVjfCGh7YAw@mail.gmail.com>
On Mon, Mar 29, 2021 at 07:01:44AM -0700, Michael Chan wrote:
> On Mon, Mar 29, 2021 at 1:52 AM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > There is no need in any indirection complexity for one ULP user,
> > remove all this complexity in favour of direct calls to the exported
> > symbols. This allows us to greatly simplify the code.
>
> The goal is not to have a hard dependency between the RDMA driver and
> the ethernet driver. One day, there may be a newer ethernet driver
> for newer devices. The RDMA driver may be the same because it
> operates at a higher level. The hard dependency will require the
> older ethernet driver to always be loaded even if it is not needed.
Then someday you will fix it. Today you do not have this, so it needs
to be deleted.
If you ever get to that point you will need to rework this driver to
use auxillary bus/etc, and it will look very different anyhow.
Jason
next prev parent reply other threads:[~2021-03-29 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 8:52 [PATCH rdma-next v1 0/5] Get rid of custom made module dependency Leon Romanovsky
2021-03-29 8:52 ` [PATCH rdma-next v1 1/5] RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it Leon Romanovsky
2021-03-29 8:52 ` [PATCH rdma-next v1 2/5] RDMA/bnxt_re: Create direct symbolic link between bnxt modules Leon Romanovsky
2021-03-29 8:52 ` [PATCH rdma-next v1 3/5] RDMA/bnxt_re: Get rid of custom module reference counting Leon Romanovsky
2021-03-29 8:52 ` [PATCH rdma-next v1 4/5] net/bnxt: Remove useless check of non-existent ULP id Leon Romanovsky
2021-03-29 8:52 ` [PATCH rdma-next v1 5/5] net/bnxt: Use direct API instead of useless indirection Leon Romanovsky
2021-03-29 14:01 ` Michael Chan
2021-03-29 14:16 ` Jason Gunthorpe [this message]
2021-03-29 18:12 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329141625.GA2356281@nvidia.com \
--to=jgg@nvidia.com \
--cc=davem@davemloft.net \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).