From: Stanislav Fomichev <sdf@google.com>
To: netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net,
Stanislav Fomichev <sdf@google.com>
Subject: [PATCH bpf-next] tools/resolve_btfids: Fix warnings
Date: Mon, 29 Mar 2021 09:24:16 -0700 [thread overview]
Message-ID: <20210329162416.2712509-1-sdf@google.com> (raw)
* make eprintf static, used only in main.c
* initialize ret in eprintf
* remove unused *tmp
Signed-off-by: Stanislav Fomichev <sdf@google.com>
---
tools/bpf/resolve_btfids/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
index 80d966cfcaa1..a650422f7430 100644
--- a/tools/bpf/resolve_btfids/main.c
+++ b/tools/bpf/resolve_btfids/main.c
@@ -115,10 +115,10 @@ struct object {
static int verbose;
-int eprintf(int level, int var, const char *fmt, ...)
+static int eprintf(int level, int var, const char *fmt, ...)
{
va_list args;
- int ret;
+ int ret = 0;
if (var >= level) {
va_start(args, fmt);
@@ -403,7 +403,7 @@ static int symbols_collect(struct object *obj)
* __BTF_ID__* over .BTF_ids section.
*/
for (i = 0; !err && i < n; i++) {
- char *tmp, *prefix;
+ char *prefix;
struct btf_id *id;
GElf_Sym sym;
int err = -1;
--
2.31.0.291.g576ba9dcdaf-goog
next reply other threads:[~2021-03-29 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 16:24 Stanislav Fomichev [this message]
2021-03-29 16:39 ` [PATCH bpf-next] tools/resolve_btfids: Fix warnings sdf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329162416.2712509-1-sdf@google.com \
--to=sdf@google.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).