From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F1DAC43140 for ; Thu, 1 Apr 2021 17:42:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0153761287 for ; Thu, 1 Apr 2021 17:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235288AbhDARmc (ORCPT ); Thu, 1 Apr 2021 13:42:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47172 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234430AbhDARhW (ORCPT ); Thu, 1 Apr 2021 13:37:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617298642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FAcr8pXoLHOnlVL/rhuQMUM4ZAj5tkENVSYWuN/yATY=; b=i0/qEqNy8fnImUQD8v7oYEQhAYkrDxosx0WGYOVtlnHEH03mNQmp3DLu2YW/sR+nf719X2 ed3gkojwjzfgIuKGJodwsgV3dLZmwmYvmYdF0jKfL/9m5DZqifYBMSLTWJcRC45RovgZGv wdI3TOQ+40sNlgqgguDaTejLp9GrmrU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-537-QblOk5EbPOmPu7Kelpz0BA-1; Thu, 01 Apr 2021 09:36:46 -0400 X-MC-Unique: QblOk5EbPOmPu7Kelpz0BA-1 Received: by mail-wm1-f69.google.com with SMTP id w185so872766wmg.4 for ; Thu, 01 Apr 2021 06:36:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FAcr8pXoLHOnlVL/rhuQMUM4ZAj5tkENVSYWuN/yATY=; b=TyDnh5iUMbJcXynKrMrFSmjCQgtKd0bK3NuUvjiQqVzY5lSO1x0legwdoAHZIBSHDk ApwSu+S43yTE5oJjlLGNnEK3FSSbmowDrVs5QumYvCgtQEZ9OenyWqulV+n6vvMdQh/0 zxlHxRKA5+Heh9P6ntoyzoxWJ8eKYioUOL7HobMG1cDsPhXO7Bl57YNz3mvQBTFDxXMe qGaWOIxGRIuH54ObR87nQf4p5m/fWN8c1hyXnFa5TsJe7dEm6iNKrFBh0K+W7sHbIc6n HkzxlGFkugV6X7v+B3obVIHZG3hwAdSAZuW+0q462ArZ120i8eKR9y9ifyfa7wMjCwuN WR+Q== X-Gm-Message-State: AOAM533AU7XXLeiOYx2Vedu3gk4KWWMuOXDS3jjYfGSu/AeHhjGZsJ8D kyBh8cCGneEYnv7tX1wRt/FZVQ9qOqhJetdXW+3KZSEfVdimm2rwloNtKhk3l/vyYuThuqbTrR+ M0oAYNoNcjOiQ27E2 X-Received: by 2002:a05:600c:2301:: with SMTP id 1mr8326134wmo.36.1617284205053; Thu, 01 Apr 2021 06:36:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0JOYRhoznK/pSpWOhrhLO7/CKato7k3tnYPJ4mMEfu3NXWv5MghnjlfWaYrbAJqDMFNE45Q== X-Received: by 2002:a05:600c:2301:: with SMTP id 1mr8326109wmo.36.1617284204821; Thu, 01 Apr 2021 06:36:44 -0700 (PDT) Received: from redhat.com ([2a10:800e:f0d3:0:b69b:9fb8:3947:5636]) by smtp.gmail.com with ESMTPSA id z66sm8835775wmc.4.2021.04.01.06.36.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 06:36:42 -0700 (PDT) Date: Thu, 1 Apr 2021 09:36:36 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: Eric Dumazet , netdev , Alexander Duyck , Paolo Abeni , Greg Thelen , "David S . Miller" , Jakub Kicinski , su-lifan@linux.alibaba.com, "dust.li" , Jason Wang , Eric Dumazet Subject: Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs Message-ID: <20210401093602-mutt-send-email-mst@kernel.org> References: <20210331040405-mutt-send-email-mst@kernel.org> <1617190239.1035674-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617190239.1035674-1-xuanzhuo@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 31, 2021 at 07:30:39PM +0800, Xuan Zhuo wrote: > On Wed, 31 Mar 2021 04:11:12 -0400, Michael S. Tsirkin wrote: > > On Mon, Mar 29, 2021 at 11:06:09AM +0200, Eric Dumazet wrote: > > > On Mon, Mar 29, 2021 at 10:52 AM Xuan Zhuo wrote: > > > > > > > > On Wed, 13 Jan 2021 08:18:19 -0800, Eric Dumazet wrote: > > > > > From: Eric Dumazet > > > > > > > > > > Both virtio net and napi_get_frags() allocate skbs > > > > > with a very small skb->head > > > > > > > > > > While using page fragments instead of a kmalloc backed skb->head might give > > > > > a small performance improvement in some cases, there is a huge risk of > > > > > under estimating memory usage. > > > > > > > > > > For both GOOD_COPY_LEN and GRO_MAX_HEAD, we can fit at least 32 allocations > > > > > per page (order-3 page in x86), or even 64 on PowerPC > > > > > > > > > > We have been tracking OOM issues on GKE hosts hitting tcp_mem limits > > > > > but consuming far more memory for TCP buffers than instructed in tcp_mem[2] > > > > > > > > > > Even if we force napi_alloc_skb() to only use order-0 pages, the issue > > > > > would still be there on arches with PAGE_SIZE >= 32768 > > > > > > > > > > This patch makes sure that small skb head are kmalloc backed, so that > > > > > other objects in the slab page can be reused instead of being held as long > > > > > as skbs are sitting in socket queues. > > > > > > > > > > Note that we might in the future use the sk_buff napi cache, > > > > > instead of going through a more expensive __alloc_skb() > > > > > > > > > > Another idea would be to use separate page sizes depending > > > > > on the allocated length (to never have more than 4 frags per page) > > > > > > > > > > I would like to thank Greg Thelen for his precious help on this matter, > > > > > analysing crash dumps is always a time consuming task. > > > > > > > > > > > > This patch causes a performance degradation of about 10% in the scenario of > > > > virtio-net + GRO. > > > > > > > > For GRO, there is no way to merge skbs based on frags with this patch, only > > > > frag_list can be used to link skbs. The problem that this cause are that compared > > > > to the GRO package merged into the frags way, the current skb needs to call > > > > kfree_skb_list to release each skb, resulting in performance degradation. > > > > > > > > virtio-net will store some data onto the linear space after receiving it. In > > > > addition to the header, there are also some payloads, so "headlen <= offset" > > > > fails. And skb->head_frag is failing when use kmalloc() for skb->head allocation. > > > > > > > > > > Thanks for the report. > > > > > > There is no way we can make things both fast for existing strategies > > > used by _insert_your_driver > > > and malicious usages of data that can sit for seconds/minutes in socket queues. > > > > > > I think that if you want to gain this 10% back, you have to change > > > virtio_net to meet optimal behavior. > > > > > > Normal drivers make sure to not pull payload in skb->head, only headers. > > > > Hmm we do have hdr_len field, but seem to ignore it on RX. > > Jason do you see any issues with using it for the head len? > > > > Why not add a struct skb_shared_info space when adding merge/big buffer? > So that we can use build_skb to create skb. For skb with little data, we can > copy directly to save pages. > > Thanks. Not 100% sure what do you mean ... want to post the patch? > > > > > Optimal GRO packets are when payload is in page fragments. > > > > > > (I am speaking not only for raw performance, but ability for systems > > > to cope with network outages and sudden increase of memory usage in > > > out of order queues) > > > > > > This has been quite clearly stated in my changelog. > > > > > > Thanks. > > > > > > > > > > int skb_gro_receive(struct sk_buff *p, struct sk_buff *skb) > > > > { > > > > struct skb_shared_info *pinfo, *skbinfo = skb_shinfo(skb); > > > > unsigned int offset = skb_gro_offset(skb); > > > > unsigned int headlen = skb_headlen(skb); > > > > > > > > ....... > > > > > > > > if (headlen <= offset) { // virtio-net will fail > > > > ........ // merge by frags > > > > goto done; > > > > } else if (skb->head_frag) { // skb->head_frag is fail when use kmalloc() for skb->head allocation > > > > ........ // merge by frags > > > > goto done; > > > > } > > > > > > > > merge: > > > > ...... > > > > > > > > if (NAPI_GRO_CB(p)->last == p) > > > > skb_shinfo(p)->frag_list = skb; > > > > else > > > > NAPI_GRO_CB(p)->last->next = skb; > > > > > > > > ...... > > > > return 0; > > > > } > > > > > > > > > > > > test cmd: > > > > for i in $(seq 1 4) > > > > do > > > > redis-benchmark -r 10000000 -n 10000000 -t set -d 1024 -c 8 -P 32 -h -p 6379 2>&1 | grep 'per second' & > > > > done > > > > > > > > Reported-by: su-lifan@linux.alibaba.com > > > > > > > > > > > > > > Fixes: fd11a83dd363 ("net: Pull out core bits of __netdev_alloc_skb and add __napi_alloc_skb") > > > > > Signed-off-by: Eric Dumazet > > > > > Cc: Alexander Duyck > > > > > Cc: Paolo Abeni > > > > > Cc: Michael S. Tsirkin > > > > > Cc: Greg Thelen > > > > > --- > > > > > net/core/skbuff.c | 9 +++++++-- > > > > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > > > > > index 7626a33cce590e530f36167bd096026916131897..3a8f55a43e6964344df464a27b9b1faa0eb804f3 100644 > > > > > --- a/net/core/skbuff.c > > > > > +++ b/net/core/skbuff.c > > > > > @@ -501,13 +501,17 @@ EXPORT_SYMBOL(__netdev_alloc_skb); > > > > > struct sk_buff *__napi_alloc_skb(struct napi_struct *napi, unsigned int len, > > > > > gfp_t gfp_mask) > > > > > { > > > > > - struct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache); > > > > > + struct napi_alloc_cache *nc; > > > > > struct sk_buff *skb; > > > > > void *data; > > > > > > > > > > len += NET_SKB_PAD + NET_IP_ALIGN; > > > > > > > > > > - if ((len > SKB_WITH_OVERHEAD(PAGE_SIZE)) || > > > > > + /* If requested length is either too small or too big, > > > > > + * we use kmalloc() for skb->head allocation. > > > > > + */ > > > > > + if (len <= SKB_WITH_OVERHEAD(1024) || > > > > > + len > SKB_WITH_OVERHEAD(PAGE_SIZE) || > > > > > (gfp_mask & (__GFP_DIRECT_RECLAIM | GFP_DMA))) { > > > > > skb = __alloc_skb(len, gfp_mask, SKB_ALLOC_RX, NUMA_NO_NODE); > > > > > if (!skb) > > > > > @@ -515,6 +519,7 @@ struct sk_buff *__napi_alloc_skb(struct napi_struct *napi, unsigned int len, > > > > > goto skb_success; > > > > > } > > > > > > > > > > + nc = this_cpu_ptr(&napi_alloc_cache); > > > > > len += SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); > > > > > len = SKB_DATA_ALIGN(len); > > > > > > > > > > -- > > > > > 2.30.0.284.gd98b1dd5eaa7-goog > > > > > > >