From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFCB4C433B4 for ; Sat, 3 Apr 2021 14:06:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3D2B611ED for ; Sat, 3 Apr 2021 14:06:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236628AbhDCOFo (ORCPT ); Sat, 3 Apr 2021 10:05:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230440AbhDCOFl (ORCPT ); Sat, 3 Apr 2021 10:05:41 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3F3BC0613E6; Sat, 3 Apr 2021 07:05:38 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id dd20so827838edb.12; Sat, 03 Apr 2021 07:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Gr5sUZoA0I/5zcq34lqqOFzBvmsdkhLPsA9GdyxgGFI=; b=STddPVtr3tIM9EcAZ1GKjQXAeC4jQAjsHB/u02ct35griIwdwIkpArrBgI89Tizykg D7EakXwPWembJzJXiRbr17FehVzY4qHXdHbUlrLeBcgZ5yJrGHKZT/0WG9vZw5m6RYbG LAMyP0miXCn6VsSrR/zd6xEcwNElDc6YXsKt+ydnnjVjNAzMCcdmwVAWaS+o4AFnJ4Oc n1nTyWICDPVlSsTD82XDCzC+v9FiM1yn5tURsvTsiW53on5fcVA+fToJpRxgabxcSL6A w8KQNR3m899mSSyZITudNMz5Z5UP3XpAZouT+Bw0qfoQ+x5i3Ailsp/eOH/kcxXer59l bjTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Gr5sUZoA0I/5zcq34lqqOFzBvmsdkhLPsA9GdyxgGFI=; b=fToYdskLHx/YWk09gxWaGLlZHKEdJV6p00c0lrnWoFaB3271SpABUZVpWIkg3S+k9B J8vrqqv9WvlsFCcscQNQF1NedZO3UpOGH1kLBI6xE9F3oMz0o3rR13GPMQSRV4NSOBwt PWTUb7sq00ak2g1iYpLewFYJO1t8QZcWiq6lQAt58zgaqBRlKEFvDBsvKbkH8d/x/1f7 GEaEAMj92OJmLY2ZmkINAdhpBFQUnsJWt+jxGDMhZ3Is0M0rduv13vIxS3ciE2mmMYzu dR2BV1d1mcea4dfTNCgCuxxGnQTRDew28nj8Zq7W0FFMFn/FvHBrWHkjtdVXVjCQELKQ YN/w== X-Gm-Message-State: AOAM5329d7+06dLE9BGM774POZU3g0qeQVeovXZ74YvAzSxr4VH3bRVj ebLVeWaOR3YI7x4TR8PpETg= X-Google-Smtp-Source: ABdhPJxao6+CxhL788xbXrHjGzZRZIMDAEnMuPQ055OZFjtix/ZD7XBl2UQXDAXj084VKhj6iJs5Bg== X-Received: by 2002:a05:6402:4407:: with SMTP id y7mr21248404eda.247.1617458736372; Sat, 03 Apr 2021 07:05:36 -0700 (PDT) Received: from skbuf (5-12-16-165.residential.rdsnet.ro. [5.12.16.165]) by smtp.gmail.com with ESMTPSA id h15sm7079339edb.74.2021.04.03.07.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Apr 2021 07:05:36 -0700 (PDT) Date: Sat, 3 Apr 2021 17:05:34 +0300 From: Vladimir Oltean To: Oleksij Rempel Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Russell King , Pengutronix Kernel Team , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH net-next v1 1/9] net: dsa: add rcv_post call back Message-ID: <20210403140534.c4ydlgu5hqh7bmcq@skbuf> References: <20210403114848.30528-1-o.rempel@pengutronix.de> <20210403114848.30528-2-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210403114848.30528-2-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Apr 03, 2021 at 01:48:40PM +0200, Oleksij Rempel wrote: > Some switches (for example ar9331) do not provide enough information > about forwarded packets. If the switch decision was made based on IPv4 > or IPv6 header, we need to analyze it and set proper flag. > > Potentially we can do it in existing rcv path, on other hand we can > avoid part of duplicated work and let the dsa framework set skb header > pointers and then use preprocessed skb one step later withing the rcv_post > call back. > > This patch is needed for ar9331 switch. > > Signed-off-by: Oleksij Rempel > --- I don't necessarily disagree with this, perhaps we can even move Florian's dsa_untag_bridge_pvid() call inside a rcv_post() method implemented by the DSA_TAG_PROTO_BRCM_LEGACY, DSA_TAG_PROTO_BRCM_PREPEND and DSA_TAG_PROTO_BRCM taggers. Or even better, because Oleksij's rcv_post is already prototype-compatible with dsa_untag_bridge_pvid, we can already do: .rcv_post = dsa_untag_bridge_pvid, This should be generally useful for stuff that DSA taggers need to do which is easiest done after eth_type_trans() was called.