Re: [PATCH net-next 3/3] dt-bindings: net: dsa: Document dsa,tag-protocol property

Rob Herring
2021-03-27T18:14:24Z

On Fri, Mar 26, 2021 at 11:56:48AM +0100, Tobias Waldekranz wrote:
> The 'dsa,tag-protocol' is used to force a switch tree to use a
> particular tag protocol, typically because the Ethernet controller
> that it is connected to is not compatible with the default one.
>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> ---
> Documentation/devicetree/bindings/net/dsa/dsa.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> index 8a3494db4d8d..5dcfab049aa2 100644
> --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> @@ -70,6 +70,13 @@ patternProperties:
> device is what the switch port is connected to
> $ref: /schemas/types.yaml#/definitions/phandle
>
> + dsa,tag-protocol:

'dsa' is not a vendor.

> + description:
> + Instead of the default, the switch will use this tag protocol if
> + possible. Useful when a device supports multiple protcols and
> + the default is incompatible with the Ethernet device.
> + $ref: /schemas/types.yaml#/definitions/string

You need to define the possible strings.

> +
> phy-handle: true
>
> phy-mode: true
> --
> 2.25.1
>