From: Christian Poessinger <christian@poessinger.com>
To: <stephen@networkplumber.org>
Cc: <christian@poessinger.com>, <netdev@vger.kernel.org>,
<u9012063@gmail.com>
Subject: [PATCH] erspan/erspan6: fix JSON output
Date: Fri, 9 Apr 2021 12:49:47 +0200 [thread overview]
Message-ID: <20210409104947.36827-1-christian@poessinger.com> (raw)
In-Reply-To: <20210406162802.9041-1-stephen@networkplumber.org>
The format for erspan/erspan6 output is not valid JSON, as on version 2 a
valueless key was presented. The direction should be value and erspan_dir
should be the key.
Fixes: 289763626721 ("erspan: add erspan version II support")
Cc: u9012063@gmail.com
Cc: Stephen Hemminger <stephen@networkplumber.org>
Reported-by: Christian Poessinger <christian@poessinger.com>
Signed-off-by: Christian Poessinger <christian@poessinger.com>
---
ip/link_gre.c | 4 ++--
ip/link_gre6.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ip/link_gre.c b/ip/link_gre.c
index 0461e5d0..6d4a8be8 100644
--- a/ip/link_gre.c
+++ b/ip/link_gre.c
@@ -536,10 +536,10 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
if (erspan_dir == 0)
print_string(PRINT_ANY, "erspan_dir",
- "erspan_dir ingress ", NULL);
+ "erspan_dir %s ", "ingress");
else
print_string(PRINT_ANY, "erspan_dir",
- "erspan_dir egress ", NULL);
+ "erspan_dir %s ", "egress");
}
if (tb[IFLA_GRE_ERSPAN_HWID]) {
diff --git a/ip/link_gre6.c b/ip/link_gre6.c
index 9d270f4b..f33598af 100644
--- a/ip/link_gre6.c
+++ b/ip/link_gre6.c
@@ -594,10 +594,10 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
if (erspan_dir == 0)
print_string(PRINT_ANY, "erspan_dir",
- "erspan_dir ingress ", NULL);
+ "erspan_dir %s ", "ingress");
else
print_string(PRINT_ANY, "erspan_dir",
- "erspan_dir egress ", NULL);
+ "erspan_dir %s ", "egress");
}
if (tb[IFLA_GRE_ERSPAN_HWID]) {
--
2.20.1
next prev parent reply other threads:[~2021-04-09 15:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 8:07 iproute2 ERSPAN version 2 JSON output shows valueless key Christian Pössinger
2021-04-06 16:28 ` [PATCH iproute2] erspan: fix JSON output Stephen Hemminger
2021-04-06 16:40 ` William Tu
2021-04-09 10:49 ` Christian Poessinger [this message]
2021-04-12 16:35 ` [PATCH] erspan/erspan6: " William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409104947.36827-1-christian@poessinger.com \
--to=christian@poessinger.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).