From: Florian Westphal <fw@strlen.de>
To: Michal Soltys <msoltyspl@yandex.pl>
Cc: Ido Schimmel <idosch@idosch.org>,
Linux Netdev List <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [BUG / question] in routing rules, some options (e.g. ipproto, sport) cause rules to be ignored in presence of packet marks
Date: Fri, 9 Apr 2021 15:02:41 +0200 [thread overview]
Message-ID: <20210409130241.GB22648@breakpoint.cc> (raw)
In-Reply-To: <24ebb842-cb3a-e1a2-c83d-44b4a5757200@yandex.pl>
Michal Soltys <msoltyspl@yandex.pl> wrote:
> On 3/29/21 10:52 PM, Ido Schimmel wrote:
> >
> > ip_route_me_harder() does not set source / destination port in the
> > flow key, so it explains why fib rules that use them are not hit after
> > mangling the packet. These keys were added in 4.17, but I
> > don't think this use case every worked. You have a different experience?
> >
>
> So all the more recent additions to routing rules - src port, dst port, uid
> range and ipproto - are not functioning correctly with the second routing
> check.
>
> Are there plans to eventually fix that ?
>
> While I just adjusted/rearranged my stuff to not rely on those, it should
> probably be at least documented otherwise (presumably in ip-rule manpage and
> perhaps in `ip rule help` as well).
Fixing this would be better. As Ido implies it should be enough to fully
populate the flow keys in ip(6)_route_me_harder.
next prev parent reply other threads:[~2021-04-09 13:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 14:05 [BUG / question] in routing rules, some options (e.g. ipproto, sport) cause rules to be ignored in presence of packet marks Michal Soltys
2021-03-29 15:42 ` Michal Soltys
2021-03-29 20:52 ` Ido Schimmel
2021-03-29 21:18 ` Ido Schimmel
2021-03-30 11:46 ` Michal Soltys
2021-04-09 12:11 ` Michal Soltys
2021-04-09 13:02 ` Florian Westphal [this message]
2021-04-09 13:20 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409130241.GB22648@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=msoltyspl@yandex.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).