From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D2DAC43461 for ; Mon, 12 Apr 2021 16:23:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A3A360FD7 for ; Mon, 12 Apr 2021 16:23:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238872AbhDLQXU (ORCPT ); Mon, 12 Apr 2021 12:23:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:54702 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243042AbhDLQXS (ORCPT ); Mon, 12 Apr 2021 12:23:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5A70D6121F; Mon, 12 Apr 2021 16:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618244580; bh=krV1K4j+48ccwbbz7TQE71hv/SiAMhVAAlfz7lT4FYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l3gPw3SlGcZSza8u9is2X1fSBcQfIdjF8JKN+h0nWbT1RlQj5aUFGN9BeepQ9aGtN dT6sjYvU57yGvZGR8shK9Mi6S7gTruWJ+mbWEViqUIOFpbEuxA3fHmA6l8RroMGcPh heY3THsazWLf9gp2vMLSDY3P0rLHFnJMx0mna2/rSXnRpNpqqFDZuoYTWlFSnYnkAl 9ImhFpulUjl/gx5mLF/G2f4drzIIPBWF2nfxhiTX5MAR4GLTf9qd1tUymgdq8hvmG+ Y0gk7XhoopxRXRcU24eRTolnsbmWgKbfQH7oB2LHEwe/XiulVPyV7JvhzMV+PLiqcJ t2upbwxu3w8cA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexander Aring , syzbot+d946223c2e751d136c94@syzkaller.appspotmail.com, Stefan Schmidt , Sasha Levin , linux-wpan@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.11 02/51] net: ieee802154: fix nl802154 del llsec dev Date: Mon, 12 Apr 2021 12:22:07 -0400 Message-Id: <20210412162256.313524-2-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210412162256.313524-1-sashal@kernel.org> References: <20210412162256.313524-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Alexander Aring [ Upstream commit 3d1eac2f45585690d942cf47fd7fbd04093ebd1b ] This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVICE is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+d946223c2e751d136c94@syzkaller.appspotmail.com Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20210221174321.14210-2-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c index 2f0a138bd5eb..063b12cba71f 100644 --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1758,7 +1758,8 @@ static int nl802154_del_llsec_dev(struct sk_buff *skb, struct genl_info *info) struct nlattr *attrs[NL802154_DEV_ATTR_MAX + 1]; __le64 extended_addr; - if (nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack)) + if (!info->attrs[NL802154_ATTR_SEC_DEVICE] || + nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack)) return -EINVAL; if (!attrs[NL802154_DEV_ATTR_EXTENDED_ADDR]) -- 2.30.2