From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: stefanc@marvell.com
Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com,
davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com,
linux-kernel@vger.kernel.org, kuba@kernel.org, mw@semihalf.com,
andrew@lunn.ch, atenart@kernel.org, lironh@marvell.com,
danat@marvell.com
Subject: Re: [PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values
Date: Tue, 13 Apr 2021 10:17:42 +0100 [thread overview]
Message-ID: <20210413091741.GL1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <1618303531-16050-1-git-send-email-stefanc@marvell.com>
On Tue, Apr 13, 2021 at 11:45:31AM +0300, stefanc@marvell.com wrote:
> From: Stefan Chulski <stefanc@marvell.com>
>
> Add parser entries for different IPv4 IHL values.
> Each entry will set the L4 header offset according to the IPv4 IHL field.
> L3 header offset will set during the parsing of the IPv4 protocol.
What is the impact of this commit? Is something broken at the moment,
if so what? Does this need to be backported to stable kernels?
These are key questions, of which the former two should be covered in
every commit message so that the reason for the change can be known.
It's no good just describing what is being changed in the commit without
also describing why the change is being made.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-04-13 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 8:45 [PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values stefanc
2021-04-13 9:17 ` Russell King - ARM Linux admin [this message]
2021-04-13 9:34 ` [EXT] " Stefan Chulski
2021-04-13 9:55 ` Stefan Chulski
2021-04-13 9:59 ` Marcin Wojtas
2021-04-13 10:03 ` Stefan Chulski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413091741.GL1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=danat@marvell.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lironh@marvell.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).