From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, michael.chan@broadcom.com,
saeedm@nvidia.com, leon@kernel.org, ecree.xilinx@gmail.com,
habetsm.xilinx@gmail.com, f.fainelli@gmail.com, andrew@lunn.ch,
mkubecek@suse.cz, ariela@nvidia.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 0/6] ethtool: add standard FEC statistics
Date: Tue, 13 Apr 2021 20:44:48 -0700 [thread overview]
Message-ID: <20210414034454.1970967-1-kuba@kernel.org> (raw)
Hi!
This set adds uAPI for reporting standard FEC statistics, and
implements it in a handful of drivers.
The statistics are taken from the IEEE standard, with one
extra seemingly popular but not standard statistics added.
The implementation is similar to that of the pause frame
statistics, user requests the stats by setting a bit
(ETHTOOL_FLAG_STATS) in the common ethtool header of
ETHTOOL_MSG_FEC_GET.
Since standard defines the statistics per lane what's
reported is both total and per-lane counters:
# ethtool -I --show-fec eth0
FEC parameters for eth0:
Configured FEC encodings: None
Active FEC encoding: None
Statistics:
corrected_blocks: 256
Lane 0: 255
Lane 1: 1
uncorrectable_blocks: 145
Lane 0: 128
Lane 1: 17
The driver implementations are compile-tested only.
I'm also guessing the semantics, so careful review
from maintainers would be much appreciated!
Jakub Kicinski (6):
ethtool: move ethtool_stats_init
ethtool: fec_prepare_data() - jump to error handling
ethtool: add FEC statistics
bnxt: implement ethtool::get_fec_stats
sfc: ef10: implement ethtool::get_fec_stats
mlx5: implement ethtool::get_fec_stats
Documentation/networking/ethtool-netlink.rst | 21 +++++
Documentation/networking/statistics.rst | 2 +
.../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 15 ++++
.../ethernet/mellanox/mlx5/core/en_ethtool.c | 9 +++
.../ethernet/mellanox/mlx5/core/en_stats.c | 28 ++++++-
.../ethernet/mellanox/mlx5/core/en_stats.h | 2 +
drivers/net/ethernet/sfc/ef10.c | 17 ++++
drivers/net/ethernet/sfc/ethtool.c | 10 +++
drivers/net/ethernet/sfc/net_driver.h | 3 +
include/linux/ethtool.h | 46 +++++++++++
include/uapi/linux/ethtool_netlink.h | 14 ++++
net/ethtool/fec.c | 80 ++++++++++++++++++-
net/ethtool/pause.c | 6 --
13 files changed, 241 insertions(+), 12 deletions(-)
--
2.30.2
next reply other threads:[~2021-04-14 3:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 3:44 Jakub Kicinski [this message]
2021-04-14 3:44 ` [PATCH net-next 1/6] ethtool: move ethtool_stats_init Jakub Kicinski
2021-04-14 3:44 ` [PATCH net-next 2/6] ethtool: fec_prepare_data() - jump to error handling Jakub Kicinski
2021-04-14 3:44 ` [PATCH net-next 3/6] ethtool: add FEC statistics Jakub Kicinski
2021-04-15 6:25 ` Saeed Mahameed
2021-04-15 15:21 ` Jakub Kicinski
2021-04-15 22:33 ` Saeed Mahameed
2021-04-14 3:44 ` [PATCH net-next 4/6] bnxt: implement ethtool::get_fec_stats Jakub Kicinski
2021-04-15 20:58 ` Michael Chan
2021-04-14 3:44 ` [PATCH net-next 5/6] sfc: ef10: " Jakub Kicinski
2021-04-19 12:39 ` Edward Cree
2021-04-14 3:44 ` [PATCH net-next 6/6] mlx5: " Jakub Kicinski
2021-04-15 6:37 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414034454.1970967-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=ariela@nvidia.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=habetsm.xilinx@gmail.com \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).