From: Lijun Pan <lijunp213@gmail.com>
To: netdev@vger.kernel.org
Cc: Lijun Pan <lijunp213@gmail.com>
Subject: [PATCH net 3/3] ibmvnic: remove duplicate napi_schedule call in open function
Date: Wed, 14 Apr 2021 02:46:16 -0500 [thread overview]
Message-ID: <20210414074616.11299-4-lijunp213@gmail.com> (raw)
In-Reply-To: <20210414074616.11299-1-lijunp213@gmail.com>
Remove the unnecessary napi_schedule() call in __ibmvnic_open() since
interrupt_rx() calls napi_schedule_prep/__napi_schedule during every
receive interrupt.
Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
Signed-off-by: Lijun Pan <lijunp213@gmail.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index f4bd63216672..ffb2a91750c7 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1156,11 +1156,6 @@ static int __ibmvnic_open(struct net_device *netdev)
netif_tx_start_all_queues(netdev);
- if (prev_state == VNIC_CLOSED) {
- for (i = 0; i < adapter->req_rx_queues; i++)
- napi_schedule(&adapter->napi[i]);
- }
-
adapter->state = VNIC_OPEN;
return rc;
}
--
2.23.0
next prev parent reply other threads:[~2021-04-14 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 7:46 [PATCH net 0/3] ibmvnic: correctly call NAPI APIs Lijun Pan
2021-04-14 7:46 ` [PATCH net 1/3] ibmvnic: avoid calling napi_disable() twice Lijun Pan
2021-04-14 7:46 ` [PATCH net 2/3] ibmvnic: remove duplicate napi_schedule call in do_reset function Lijun Pan
2021-04-14 7:46 ` Lijun Pan [this message]
2021-04-14 20:20 ` [PATCH net 0/3] ibmvnic: correctly call NAPI APIs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414074616.11299-4-lijunp213@gmail.com \
--to=lijunp213@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).