From: Du Cheng <ducheng2@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
eric.dumazet@gmail.com, Du Cheng <ducheng2@gmail.com>,
syzbot+d50710fd0873a9c6b40c@syzkaller.appspotmail.com
Subject: [PATCH v2] net: sched: tapr: remove WARN_ON() in taprio_get_start_time
Date: Thu, 15 Apr 2021 15:59:53 +0800 [thread overview]
Message-ID: <20210415075953.83508-2-ducheng2@gmail.com> (raw)
In-Reply-To: <20210415075953.83508-1-ducheng2@gmail.com>
There is a reproducible sequence from the userland that will trigger a WARN_ON()
condition in taprio_get_start_time, which causes kernel to panic if configured
as "panic_on_warn". Remove this WARN_ON() to prevent kernel from crashing by
userland-initiated syscalls.
Reported as bug on syzkaller:
https://syzkaller.appspot.com/bug?extid=d50710fd0873a9c6b40c
Reported-by: syzbot+d50710fd0873a9c6b40c@syzkaller.appspotmail.com
Signed-off-by: Du Cheng <ducheng2@gmail.com>
---
changelog:
v1: Discussion https://lore.kernel.org/netdev/YHfwUmFODUHx8G5W@carbon/T/
v2: fix typo
net/sched/sch_taprio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 8287894541e3..33a829c1ba9b 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -996,7 +996,7 @@ static int taprio_get_start_time(struct Qdisc *sch,
* something went really wrong. In that case, we should warn about this
* inconsistent state and return error.
*/
- if (WARN_ON(!cycle))
+ if (!cycle)
return -EFAULT;
/* Schedule the start time for the beginning of the next
--
2.30.2
next prev parent reply other threads:[~2021-04-15 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 6:39 [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time() Du Cheng
2021-04-15 6:56 ` Eric Dumazet
2021-04-15 7:50 ` Du Cheng
2021-04-15 18:02 ` Eric Dumazet
2021-04-15 7:59 ` [PATCH v2] " Du Cheng
2021-04-15 7:59 ` Du Cheng [this message]
2021-04-15 18:02 ` Eric Dumazet
2021-04-15 23:20 ` Du Cheng
2021-04-15 8:31 ` [PATCH] " kernel test robot
2021-04-15 9:45 ` kernel test robot
2021-04-15 18:47 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415075953.83508-2-ducheng2@gmail.com \
--to=ducheng2@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+d50710fd0873a9c6b40c@syzkaller.appspotmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).