From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: brouer@redhat.com, kerneljasonxing@gmail.com,
davem@davemloft.net, kuba@kernel.org, anthony.l.nguyen@intel.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, kpsingh@kernel.org,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
Jason Xing <xingwanli@kuaishou.com>,
Shujin Li <lishujin@kuaishou.com>
Subject: Re: [PATCH net v3] i40e: fix the panic when running bpf in xdpdrv mode
Date: Thu, 15 Apr 2021 12:31:45 +0200 [thread overview]
Message-ID: <20210415123145.56af01ca@carbon> (raw)
In-Reply-To: <20210414190652.00006680@intel.com>
On Wed, 14 Apr 2021 19:06:52 -0700
Jesse Brandeburg <jesse.brandeburg@intel.com> wrote:
> kerneljasonxing@gmail.com wrote:
>
> > From: Jason Xing <xingwanli@kuaishou.com>
> >
> > Fix this panic by adding more rules to calculate the value of @rss_size_max
> > which could be used in allocating the queues when bpf is loaded, which,
> > however, could cause the failure and then trigger the NULL pointer of
> > vsi->rx_rings. Prio to this fix, the machine doesn't care about how many
> > cpus are online and then allocates 256 queues on the machine with 32 cpus
> > online actually.
> >
> > Once the load of bpf begins, the log will go like this "failed to get
> > tracking for 256 queues for VSI 0 err -12" and this "setup of MAIN VSI
> > failed".
> >
> > Thus, I attach the key information of the crash-log here.
> >
> > BUG: unable to handle kernel NULL pointer dereference at
> > 0000000000000000
> > RIP: 0010:i40e_xdp+0xdd/0x1b0 [i40e]
> > Call Trace:
> > [2160294.717292] ? i40e_reconfig_rss_queues+0x170/0x170 [i40e]
> > [2160294.717666] dev_xdp_install+0x4f/0x70
> > [2160294.718036] dev_change_xdp_fd+0x11f/0x230
> > [2160294.718380] ? dev_disable_lro+0xe0/0xe0
> > [2160294.718705] do_setlink+0xac7/0xe70
> > [2160294.719035] ? __nla_parse+0xed/0x120
> > [2160294.719365] rtnl_newlink+0x73b/0x860
> >
> > Fixes: 41c445ff0f48 ("i40e: main driver core")
> > Co-developed-by: Shujin Li <lishujin@kuaishou.com>
> > Signed-off-by: Shujin Li <lishujin@kuaishou.com>
> > Signed-off-by: Jason Xing <xingwanli@kuaishou.com>
>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> @Jakub/@DaveM - feel free to apply this directly.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
The crash/bug happens in this code:
static int i40e_xdp_setup(struct i40e_vsi *vsi, struct bpf_prog *prog,
struct netlink_ext_ack *extack)
{
[...]
for (i = 0; i < vsi->num_queue_pairs; i++)
WRITE_ONCE(vsi->rx_rings[i]->xdp_prog, vsi->xdp_prog);
And this is a side effect of i40e_setup_pf_switch() failing with "setup
of MAIN VSI failed".
LGTM
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2021-04-15 10:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 6:57 [PATCH] i40e: fix the panic when running bpf in xdpdrv mode kerneljasonxing
2021-04-12 21:52 ` Jesse Brandeburg
2021-04-13 2:17 ` Jason Xing
2021-04-13 2:50 ` [PATCH net v2] " kerneljasonxing
2021-04-13 16:18 ` Jesse Brandeburg
2021-04-14 1:37 ` Jason Xing
2021-04-15 1:12 ` Jason Xing
2021-04-15 2:08 ` Jesse Brandeburg
2021-04-15 5:16 ` Jason Xing
2021-04-14 2:34 ` [PATCH net v3] " kerneljasonxing
2021-04-15 2:06 ` Jesse Brandeburg
2021-04-15 10:31 ` Jesper Dangaard Brouer [this message]
2021-04-15 21:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415123145.56af01ca@carbon \
--to=brouer@redhat.com \
--cc=andrii@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kerneljasonxing@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lishujin@kuaishou.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=xingwanli@kuaishou.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).