Re: [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5242 bytes --]

Hi Du,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc7 next-20210414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Du-Cheng/net-sched-tapr-remove-WARN_ON-in-taprio_get_start_time/20210415-144126
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7f75285ca572eaabc028cf78c6ab5473d0d160be
config: powerpc64-randconfig-r014-20210415 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://github.com/0day-ci/linux/commit/274f557f95031e6965d9bb0ee67fdc22f2eb9b3a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Du-Cheng/net-sched-tapr-remove-WARN_ON-in-taprio_get_start_time/20210415-144126
        git checkout 274f557f95031e6965d9bb0ee67fdc22f2eb9b3a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> net/sched/sch_taprio.c:1012:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1031:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1053:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1077:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1106:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1117:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1132:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1145:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1171:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1187:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1208:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1233:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1269:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1310:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1385:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1411:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1432:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1601:1: error: function definition is not allowed here
   {
   ^
   net/sched/sch_taprio.c:1617:1: error: function definition is not allowed here
   {
   ^
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   20 errors generated.


vim +1012 net/sched/sch_taprio.c

5a781ccbd19e46 Vinicius Costa Gomes 2018-09-28  1009  
a3d43c0d56f1b9 Vinicius Costa Gomes 2019-04-29  1010  static void setup_first_close_time(struct taprio_sched *q,
a3d43c0d56f1b9 Vinicius Costa Gomes 2019-04-29  1011  				   struct sched_gate_list *sched, ktime_t base)
5a781ccbd19e46 Vinicius Costa Gomes 2018-09-28 @1012  {
5a781ccbd19e46 Vinicius Costa Gomes 2018-09-28  1013  	struct sched_entry *first;
6ca6a6654225f3 Vinicius Costa Gomes 2019-04-29  1014  	ktime_t cycle;
5a781ccbd19e46 Vinicius Costa Gomes 2018-09-28  1015  
a3d43c0d56f1b9 Vinicius Costa Gomes 2019-04-29  1016  	first = list_first_entry(&sched->entries,
a3d43c0d56f1b9 Vinicius Costa Gomes 2019-04-29  1017  				 struct sched_entry, list);
5a781ccbd19e46 Vinicius Costa Gomes 2018-09-28  1018  
037be0374078e2 Vedang Patel         2019-06-25  1019  	cycle = sched->cycle_time;
6ca6a6654225f3 Vinicius Costa Gomes 2019-04-29  1020  
6ca6a6654225f3 Vinicius Costa Gomes 2019-04-29  1021  	/* FIXME: find a better place to do this */
6ca6a6654225f3 Vinicius Costa Gomes 2019-04-29  1022  	sched->cycle_close_time = ktime_add_ns(base, cycle);
6ca6a6654225f3 Vinicius Costa Gomes 2019-04-29  1023  
a3d43c0d56f1b9 Vinicius Costa Gomes 2019-04-29  1024  	first->close_time = ktime_add_ns(base, first->interval);
23bddf692d369c Jakub Kicinski       2019-04-17  1025  	taprio_set_budget(q, first);
5a781ccbd19e46 Vinicius Costa Gomes 2018-09-28  1026  	rcu_assign_pointer(q->current_entry, NULL);
a3d43c0d56f1b9 Vinicius Costa Gomes 2019-04-29  1027  }
5a781ccbd19e46 Vinicius Costa Gomes 2018-09-28  1028  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33881 bytes --]