From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A19BC433ED for ; Fri, 16 Apr 2021 16:40:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 662CF610EA for ; Fri, 16 Apr 2021 16:40:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236201AbhDPQkn (ORCPT ); Fri, 16 Apr 2021 12:40:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234323AbhDPQkm (ORCPT ); Fri, 16 Apr 2021 12:40:42 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4837DC061756 for ; Fri, 16 Apr 2021 09:40:16 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id q10so19566763pgj.2 for ; Fri, 16 Apr 2021 09:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qBMbrSOywNmfduS/OTT3MgG5hkK1w/tlntAgfLJqoII=; b=t7nKMlwt2xNTb0VB5O3hJidsskXOoEd+BB1LiY/DkvohgS/mG4I49FoWx/KDPdrsGs NEnjD0k2IrRndhYGwjPO0ocv4l/PR1WwYdaMupvBLARIkFqL0UCJe2To5TjDODgJr/fd Yfkygig4e4EfeFD8E6T0mDauYZ0nFZEjOFvTwY0Ok8NYTeuH1eL7gyZ3K6W+xv8xqgdi n8UaXKXQ7O0VXJJ3876gSSPZ5wa6mxYE4oUjkiTQUpof5BPnGPUgwf/TRoksXbSGUOJ5 i9KSSj50mxWvXyHPBoEWdq5yqASbmihRN4lluaTWLLYRzvaNVGECmMuBdss7TCJG+O3R P9pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qBMbrSOywNmfduS/OTT3MgG5hkK1w/tlntAgfLJqoII=; b=JFqiArlk8WE9B8I5Ia4SpEAu9y3HX5SuqGfsND6Hr3RlkfYVYerV4eHmpAUNSIMv8y pU0wbuPxCStTax2IK2AJJPO8O1SNGwdZD51WXcobzmT+xK/yROKbGmnOO2q97FPvkCuF JecK6tluUdto+0vcmgFllls4pmzgxGE9Y6bU1z8QBnMGHTwSMHkTGu0CdXMrnADfqqyD iHEQY+suCfSZwrepReDN+oBJ6eKRJVO+VYK+zohdcV2psXRi3FpzKx0slPkEI2EtddHp +YALr81Psi9mYdWZpFcJpRgJ199Oz8GRHlOh5hfc1QogCMZ7Lg4LRMUVZuVpc4upTdOY 7bqA== X-Gm-Message-State: AOAM530+k2lO4imiTWWtqq8X4i+uLWtKW77pm8cGzVopcGloRz9NwRaD Hn0vLcxLl3t+urR6z/hVMVJjeg== X-Google-Smtp-Source: ABdhPJwOxcBV/K+3tCZDrbPAFySF7Z1daXqBFUfpr1wER35W5490o1xjQaiUOIp0pkRXCU7DADaBLw== X-Received: by 2002:a62:b412:0:b029:21f:6b06:7bdd with SMTP id h18-20020a62b4120000b029021f6b067bddmr8656780pfn.51.1618591215753; Fri, 16 Apr 2021 09:40:15 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id k21sm5164664pfi.28.2021.04.16.09.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 09:40:15 -0700 (PDT) Date: Fri, 16 Apr 2021 09:40:06 -0700 From: Stephen Hemminger To: Dexuan Cui Cc: davem@davemloft.net, kuba@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, liuwe@microsoft.com, netdev@vger.kernel.org, leon@kernel.org, andrew@lunn.ch, bernd@petrovitsch.priv.at, rdunlap@infradead.org, shacharr@microsoft.com, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: Re: [PATCH v7 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA) Message-ID: <20210416094006.70661f47@hermes.local> In-Reply-To: <20210416060705.21998-1-decui@microsoft.com> References: <20210416060705.21998-1-decui@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 15 Apr 2021 23:07:05 -0700 Dexuan Cui wrote: > diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c > index 7349a70af083..f682a5572d84 100644 > --- a/drivers/net/hyperv/netvsc_drv.c > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -2297,6 +2297,7 @@ static struct net_device *get_netvsc_byslot(const struct net_device *vf_netdev) > { > struct device *parent = vf_netdev->dev.parent; > struct net_device_context *ndev_ctx; > + struct net_device *ndev; > struct pci_dev *pdev; > u32 serial; > > @@ -2319,8 +2320,17 @@ static struct net_device *get_netvsc_byslot(const struct net_device *vf_netdev) > if (!ndev_ctx->vf_alloc) > continue; > > - if (ndev_ctx->vf_serial == serial) > - return hv_get_drvdata(ndev_ctx->device_ctx); > + if (ndev_ctx->vf_serial != serial) > + continue; > + > + ndev = hv_get_drvdata(ndev_ctx->device_ctx); > + if (ndev->addr_len != vf_netdev->addr_len || > + memcmp(ndev->perm_addr, vf_netdev->perm_addr, > + ndev->addr_len) != 0) > + continue; > + > + return ndev; > + > } > > netdev_notice(vf_netdev, This probably should be a separate patch. I think it is trying to address the case of VF discovery in Hyper-V/Azure where the reported VF from Hypervisor is bogus or confused.