From: Kalle Valo <kvalo@codeaurora.org>
To: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Cc: buytenh@wantstofly.org, davem@davemloft.net, kuba@kernel.org,
gustavoars@kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Subject: Re: mwl8k: Fix a double Free in mwl8k_probe_hw
Date: Sun, 18 Apr 2021 06:35:25 +0000 (UTC) [thread overview]
Message-ID: <20210418063525.CE763C4338A@smtp.codeaurora.org> (raw)
In-Reply-To: <20210402182627.4256-1-lyl2019@mail.ustc.edu.cn>
Lv Yunlong <lyl2019@mail.ustc.edu.cn> wrote:
> In mwl8k_probe_hw, hw->priv->txq is freed at the first time by
> dma_free_coherent() in the call chain:
> if(!priv->ap_fw)->mwl8k_init_txqs(hw)->mwl8k_txq_init(hw, i).
>
> Then in err_free_queues of mwl8k_probe_hw, hw->priv->txq is freed
> at the second time by mwl8k_txq_deinit(hw, i)->dma_free_coherent().
>
> My patch set txq->txd to NULL after the first free to avoid the
> double free.
>
> Fixes: a66098daacee2 ("mwl8k: Marvell TOPDOG wireless driver")
> Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Patch applied to wireless-drivers-next.git, thanks.
a8e083ee8e2a mwl8k: Fix a double Free in mwl8k_probe_hw
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210402182627.4256-1-lyl2019@mail.ustc.edu.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-04-18 6:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 18:26 [PATCH] wireless: marvell: mwl8k: Fix a double Free in mwl8k_probe_hw Lv Yunlong
2021-04-13 16:23 ` lyl2019
2021-04-18 6:35 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210418063525.CE763C4338A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lyl2019@mail.ustc.edu.cn \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).