From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C503FC433B4 for ; Mon, 19 Apr 2021 15:53:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 930E96128C for ; Mon, 19 Apr 2021 15:53:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240250AbhDSPy2 (ORCPT ); Mon, 19 Apr 2021 11:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236540AbhDSPy1 (ORCPT ); Mon, 19 Apr 2021 11:54:27 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF1CFC06174A for ; Mon, 19 Apr 2021 08:53:57 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id i190so23460947pfc.12 for ; Mon, 19 Apr 2021 08:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cgBc8DK/uiwWd9qSl4rojF6ng4YEQX2bdE7yvqzTNqE=; b=u/oVPFKGt9zHYgML5cUAw/Efd89FKRDWGw/I98AIsuX396f+7JRPeCnIUHAHru1YT2 alg0X3wpoibmMgW+2MNttK/aM4Yl0f6ZYHI83pH39evE9PkcaLic9Fl6xyDZ1RiztV5D cb4hY/XzhuJsBWMqFuBXSTkNEEtW0pM9mhrSFYVQ7iKgpmUQAIb/jV9RoQmwn+I2SCaD XJylUweHVGOHHg5kiBEaLn2cNFptE/QUjaZuGr3UOFslqFjPbhtXVQ1kj8KbjbRR6hwB 38JVZeVYq3g9co/SPSJGM5/9scP6o6h0q29gecdtZ+eUupOg8yqaxzt7Dw2/BW06JFYw qKaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cgBc8DK/uiwWd9qSl4rojF6ng4YEQX2bdE7yvqzTNqE=; b=OBdUJjOGsFdtpMKaVLZgCfIbIKqookKZScpbNhe8zwVXGZXR0gW7N8JAAjZFLRvT30 IFlK6CJYN+7YWJLg2GWRE2RJqGjfeSQhc4/NArY3NwX6qPCZ3pv4oNtcywLA9Xf50jAj I6GlOs4dXE0zTgPWmLa9MhzraA2tYwQufB8n6O37m+ft9DCA409uMar0cqGrnUeW9i9n cvmJyyJxjWOvV5onnPDoQoHYHNebtHbestlP8YoOI4a44blu9c8sEvu76bVlncjFcD6z DSbpYmNybGup3GTMbhGIpUjnXtYy/zb/Ux+CcUgZQ3bRD3GvtoieYhS29TVcZNmK6Nck 0wag== X-Gm-Message-State: AOAM533m0dU2GSlSJO4Gyxwts+/V44vr3gJ9tA/MlIJEbDXqypfrj2b7 ykpx7JaxyN6FuRotkbrjVLfUiA== X-Google-Smtp-Source: ABdhPJxxPK27y5npo1SqwJ7a8gTGdvn/PllAqMSn62dXKMIn47wfM5wDjZYvXwAXdTmnsdwC5cinmg== X-Received: by 2002:a63:145a:: with SMTP id 26mr12295651pgu.300.1618847637567; Mon, 19 Apr 2021 08:53:57 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id m7sm1704803pfc.218.2021.04.19.08.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 08:53:57 -0700 (PDT) Date: Mon, 19 Apr 2021 08:53:48 -0700 From: Stephen Hemminger To: Dexuan Cui Cc: davem@davemloft.net, kuba@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, liuwe@microsoft.com, netdev@vger.kernel.org, leon@kernel.org, andrew@lunn.ch, bernd@petrovitsch.priv.at, rdunlap@infradead.org, shacharr@microsoft.com, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: Re: [PATCH v8 net-next 1/2] hv_netvsc: Make netvsc/VF binding check both MAC and serial number Message-ID: <20210419085348.6f5afd0b@hermes.local> In-Reply-To: <20210416201159.25807-2-decui@microsoft.com> References: <20210416201159.25807-1-decui@microsoft.com> <20210416201159.25807-2-decui@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 16 Apr 2021 13:11:58 -0700 Dexuan Cui wrote: > Currently the netvsc/VF binding logic only checks the PCI serial number. > > The upcoming Microsoft Azure Network Adapter (MANA) supports multiple > net_device interfaces (each such interface is called a "vPort", and has > its unique MAC address) which are backed by the same VF PCI device, so > the binding logic should check both the MAC address and the PCI serial > number. > > The change should not break any other existing VF drivers, because > Hyper-V NIC SR-IOV implementation requires the netvsc network > interface and the VF network interface have the same MAC address. > > Co-developed-by: Haiyang Zhang > Signed-off-by: Haiyang Zhang > Co-developed-by: Shachar Raindel > Signed-off-by: Shachar Raindel > Signed-off-by: Dexuan Cui Acked-by: Stephen Hemminger