[PATCH net-next] ethtool: stats: clarify the initialization to ETHTOOL_STAT_NOT_SET

[PATCH net-next] ethtool: stats: clarify the initialization to ETHTOOL_STAT_NOT_SET

[Jakub Kicinski]

Ido suggests we add a comment about the init of stats to -1.
This is unlikely to be clear to first time readers.

Suggested-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 net/ethtool/stats.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/ethtool/stats.c b/net/ethtool/stats.c
index acb2b080c358..b7642dc96d50 100644
--- a/net/ethtool/stats.c
+++ b/net/ethtool/stats.c
@@ -114,6 +114,9 @@ static int stats_prepare_data(const struct ethnl_req_info *req_base,
 	if (ret < 0)
 		return ret;
 
+	/* Mark all stats as unset (see ETHTOOL_STAT_NOT_SET) to prevent them
+	 * from being reported to user space in case driver did not set them.
+	 */
 	memset(&data->phy_stats, 0xff, sizeof(data->phy_stats));
 	memset(&data->mac_stats, 0xff, sizeof(data->mac_stats));
 	memset(&data->ctrl_stats, 0xff, sizeof(data->mac_stats));
-- 
2.30.2

Re: [PATCH net-next] ethtool: stats: clarify the initialization to ETHTOOL_STAT_NOT_SET

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 19 Apr 2021 13:03:45 -0700 you wrote:
> Ido suggests we add a comment about the init of stats to -1.
> This is unlikely to be clear to first time readers.
> 
> Suggested-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  net/ethtool/stats.c | 3 +++
>  1 file changed, 3 insertions(+)

Here is the summary with links:
  - [net-next] ethtool: stats: clarify the initialization to ETHTOOL_STAT_NOT_SET
    https://git.kernel.org/netdev/net-next/c/d1f0a5e1fb4e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html