From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
john@phrozen.org, nbd@nbd.name, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com, dqfext@gmail.com
Subject: Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex
Date: Tue, 20 Apr 2021 16:58:16 +0200 [thread overview]
Message-ID: <20210420145816.GA27083@salvia> (raw)
In-Reply-To: <C076C591-F541-48B3-9750-8F35B4127638@public-files.de>
On Tue, Apr 20, 2021 at 01:51:07PM +0200, Frank Wunderlich wrote:
> Am 18. April 2021 23:11:44 MESZ schrieb Pablo Neira Ayuso <pablo@netfilter.org>:
> >Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy
> >and
> >stats to different workqueues") splits the workqueue per event type.
> >Add
> >a mutex to serialize updates.
> >
> >Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading
> >support")
> >Reported-by: Frank Wunderlich <frank-w@public-files.de>
> >Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
>
> Hi Pablo,
>
> As far we tested it, the mutex does not avoid the hang. It looks a bit better,but at the end it was fixed by this Patch
>
> https://patchwork.kernel.org/project/linux-mediatek/patch/20210417072905.207032-1-dqfext@gmail.com/
>
> Alex did some tests without the lock here and it still looks stable.
> So it looks like it is not needed
It might be hard to trigger the race, but it's needed. There are
several workqueues racing to add and delete entries from the driver
flowtable representation which has no locks.
next prev parent reply other threads:[~2021-04-20 14:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 21:11 [PATCH net-next 0/3] mtk_ppe_offload fixes Pablo Neira Ayuso
2021-04-18 21:11 ` [PATCH net-next 1/3] net: ethernet: mtk_eth_soc: fix undefined reference to `dsa_port_from_netdev' Pablo Neira Ayuso
2021-04-18 21:11 ` [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex Pablo Neira Ayuso
2021-04-19 21:16 ` Jakub Kicinski
2021-04-19 21:40 ` Pablo Neira Ayuso
2021-04-19 21:43 ` Jakub Kicinski
2021-04-19 21:54 ` Pablo Neira Ayuso
2021-04-19 21:56 ` Jakub Kicinski
2021-04-20 11:51 ` Frank Wunderlich
2021-04-20 14:58 ` Pablo Neira Ayuso [this message]
2021-04-18 21:11 ` [PATCH net-next 3/3] net: ethernet: mtk_eth_soc: handle VLAN pop action Pablo Neira Ayuso
2021-04-19 23:10 ` [PATCH net-next 0/3] mtk_ppe_offload fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420145816.GA27083@salvia \
--to=pablo@netfilter.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=frank-w@public-files.de \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).