From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE6D4C433B4 for ; Wed, 21 Apr 2021 09:39:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 944F86144B for ; Wed, 21 Apr 2021 09:39:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238484AbhDUJjy (ORCPT ); Wed, 21 Apr 2021 05:39:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238357AbhDUJjt (ORCPT ); Wed, 21 Apr 2021 05:39:49 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5855EC06174A for ; Wed, 21 Apr 2021 02:39:15 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id k17so9051113edr.7 for ; Wed, 21 Apr 2021 02:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7vTQYtCuzSqSD01xdETGY8hGY6vgkDP6vbFro/3X7+o=; b=Fpp/OTXrg0aYSbMjwVz7FJ8stCIQzJoKnLJwKaRJRkWmxUOa1eqEubMr+wMVartk01 HOqI/p0RFJtp9B42b8hq6IPr+kvKLYRkhBAIywS0pWl8tY4JhObmdyq8MXDRR7verm+I I7/AsCWlD14e5OnCURQGIbLfoL8cxOJWHbPYepGxXZhflBDPXNInZpYdprYyYJuzeCvc B+XhlPfrXf5YMn2dZafwVcAzDXRebaI8P9Yer5vR6s5Q51WjffgFlIMxnjPLdSCAUHgV uwKZkqSf2wIhhRnGk5OZCfxv9BR6ZKaXCepNkHYay6PbtBEnzT/0S59jgrNHIW7CI+q1 1pmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7vTQYtCuzSqSD01xdETGY8hGY6vgkDP6vbFro/3X7+o=; b=Gz83GDNFJwpJa2tUXXeqqsTTnmAQfukfl1XsETkP+mWMxyfoe6ee6Oc2cvVvJKOK76 rMmnQZ2cprlNFNqQO6KfvmBmUhz5Cc76wdiRCG6ofPr+7g6uhhVl5mN56xon5x178N33 aBql+YiCnSg6pEx0/kHnbv8BNgUOx04REEmThUZvbcWlRNMVQGHl8VrhA+NaRHoCow/F MYvlbhVRFHAC7aOshLhFrOkh01NJU8HYjZ9edFG7BmgXFaAR2fA3nizLhy+UUNKB7lW1 Di5uKOwgw0IJx3pdiZ7PyS//rT2O4xRckXOUxVwiLSR6TJcYSsAIsOM4MRgUkPQ42bi4 D3rA== X-Gm-Message-State: AOAM532LYdEGrzQwURoWTPpjh5nk+d2FQ7YDYEtMxHvzghEDvtQMer4j BpDFQixyoKkoWN/aB9FWh+jYpw== X-Google-Smtp-Source: ABdhPJyqmSuXvxpzw7E8oxviPPUGHeFncPI7x/UT+mwZN/gqeOoEGBTZgfIrnK8OUBSp+FRq/JHfSA== X-Received: by 2002:a05:6402:46:: with SMTP id f6mr37754221edu.252.1618997954103; Wed, 21 Apr 2021 02:39:14 -0700 (PDT) Received: from netronome.com ([2001:982:7ed1:403:9eeb:e8ff:fe0d:5b6a]) by smtp.gmail.com with ESMTPSA id d1sm2423853ede.31.2021.04.21.02.39.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 02:39:13 -0700 (PDT) Date: Wed, 21 Apr 2021 11:39:12 +0200 From: Simon Horman To: "Gustavo A. R. Silva" Cc: "Gustavo A. R. Silva" , Jakub Kicinski , "David S. Miller" , oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [oss-drivers] Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang Message-ID: <20210421093911.GA15091@netronome.com> References: <20210305094937.GA141307@embeddedor> <20210305121949.GF8899@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 20, 2021 at 03:23:39PM -0500, Gustavo A. R. Silva wrote: > On 3/5/21 06:19, Simon Horman wrote: > > On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > >> by explicitly adding a break statement instead of letting the code fall > >> through to the next case. > >> > >> Link: https://github.com/KSPP/linux/issues/115 > >> Signed-off-by: Gustavo A. R. Silva > > > > Thanks Gustavo, > > > > this looks good to me. > > > > Acked-by: Simon Horman > > Hi all, > > Friendly ping: who can take this, please? Hi Jakub, Hi David, I'm happy to repost this patch if it would help with your processes. > >> --- > >> drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > >> index b3cabc274121..3b8e675087de 100644 > >> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > >> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c > >> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats) > >> case NFP_PORT_PF_PORT: > >> case NFP_PORT_VF_PORT: > >> nfp_repr_vnic_get_stats64(repr->port, stats); > >> + break; > >> default: > >> break; > >> } > >> -- > >> 2.27.0 > >>