From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95CABC433B4 for ; Wed, 21 Apr 2021 13:43:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 548E7613CD for ; Wed, 21 Apr 2021 13:43:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241066AbhDUNnw (ORCPT ); Wed, 21 Apr 2021 09:43:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:53988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242670AbhDUNnY (ORCPT ); Wed, 21 Apr 2021 09:43:24 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9C793611F2; Wed, 21 Apr 2021 13:42:43 +0000 (UTC) Date: Wed, 21 Apr 2021 09:42:41 -0400 From: Steven Rostedt To: Leon Romanovsky Cc: Trond Myklebust , "a.shelat@northeastern.edu" , "davem@davemloft.net" , "gregkh@linuxfoundation.org" , "chuck.lever@oracle.com" , "dwysocha@redhat.com" , "linux-kernel@vger.kernel.org" , "kuba@kernel.org" , "sudipm.mukherjee@gmail.com" , "bfields@fieldses.org" , "anna.schumaker@netapp.com" , "pakki001@umn.edu" , "linux-nfs@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH] SUNRPC: Add a check for gss_release_msg Message-ID: <20210421094241.1bb65758@gandalf.local.home> In-Reply-To: References: <20210407001658.2208535-1-pakki001@umn.edu> <20210420171008.GB4017@fieldses.org> <3B9A54F7-6A61-4A34-9EAC-95332709BAE7@northeastern.edu> <6530850bc6f0341d1f2d5043ba1dd04e242cff66.camel@hammerspace.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 21 Apr 2021 16:20:46 +0300 Leon Romanovsky wrote: > > There really is no alternative for maintainers other than to always be > > sceptical of patches submitted by people who are not known and trusted > > members of the community, and to scrutinise those patches with more > > care. > There's only a couple of contributors to my code that I will take without looking deeply at what it does. And those are well respected developers that many other people know. > Right, my guess is that many maintainers failed in the trap when they > saw respectful address @umn.edu together with commit message saying > about "new static analyzer tool". > > The mental bias here is to say that "oh, another academic group tries > to reinvent the wheel, looks ok". I'm skeptical of all static analyzers, as I've seen too many good ones still produce crappy fixes. I look even more carefully if I see that it was a tool that discovered the bug and not a human. The one patch from Greg's reverts that affects my code was actually a legitimate fix, and looking back at the thread of the submission, I even asked if it was found via inspection or a tool. https://lore.kernel.org/lkml/20190419223718.17fa8246@oasis.local.home/ -- Steve