From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6541DC433B4 for ; Wed, 21 Apr 2021 15:48:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1153861425 for ; Wed, 21 Apr 2021 15:48:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244086AbhDUPsc (ORCPT ); Wed, 21 Apr 2021 11:48:32 -0400 Received: from mga03.intel.com ([134.134.136.65]:7382 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243712AbhDUPsa (ORCPT ); Wed, 21 Apr 2021 11:48:30 -0400 IronPort-SDR: CDumP53UWcFtdIRuS+0LQlnZo6H5aH4HMvZVIh9DL2beQKfOfXRPjSp/I33txvh1krYnu5SUG1 FeT6Mr9XvGfA== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="195746943" X-IronPort-AV: E=Sophos;i="5.82,240,1613462400"; d="scan'208";a="195746943" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 08:47:56 -0700 IronPort-SDR: eHLdZFql0BmKUV9o3AAeOQH/5qTMuOjY6FBe3m2huykpG3k9I/xnPk46S9ndjcZy3e0NSusWDA icamdntlc9Mg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,240,1613462400"; d="scan'208";a="455391360" Received: from linux.intel.com ([10.54.29.200]) by fmsmga002.fm.intel.com with ESMTP; 21 Apr 2021 08:47:56 -0700 Received: from linux.intel.com (unknown [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 700105808CA; Wed, 21 Apr 2021 08:47:53 -0700 (PDT) Date: Wed, 21 Apr 2021 23:47:50 +0800 From: Wong Vee Khee To: Dan Carpenter Cc: Giuseppe Cavallaro , Tan Tee Min , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Maxime Coquelin , Richard Cochran , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] stmmac: intel: unlock on error path in intel_crosststamp() Message-ID: <20210421154750.GA20299@linux.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 21, 2021 at 04:22:50PM +0300, Dan Carpenter wrote: > We recently added some new locking to this function but one error path > was overlooked. We need to drop the lock before returning. > > Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping") > Signed-off-by: Dan Carpenter Reviewed-by: Wong Vee Khee