From: Kalle Valo <kvalo@codeaurora.org>
To: zhangkun4jr@163.com
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhang Kun <zhangkun@cdjrlc.com>
Subject: Re: [PATCH] ath9k:remove unneeded variable in ath9k_dump_legacy_btcoex
Date: Wed, 21 Apr 2021 17:46:10 +0000 (UTC) [thread overview]
Message-ID: <20210421174610.B4FD1C433F1@smtp.codeaurora.org> (raw)
In-Reply-To: <20210224130356.51444-1-zhangkun4jr@163.com>
zhangkun4jr@163.com wrote:
> From: Zhang Kun <zhangkun@cdjrlc.com>
>
> Remove unneeded variable 'len' in ath9k_dump_legacy_btcoex.
>
> Signed-off-by: Zhang Kun <zhangkun@cdjrlc.com>
This fails to compile. Always build check your patches!
In file included from drivers/net/wireless/ath/ath9k/gpio.c:17:
drivers/net/wireless/ath/ath9k/gpio.c: In function 'ath9k_dump_legacy_btcoex':
drivers/net/wireless/ath/ath9k/ath9k.h:763:3: error: 'len' undeclared (first use in this function)
763 | len += scnprintf(buf + len, size - len, \
| ^~~
drivers/net/wireless/ath/ath9k/gpio.c:501:2: note: in expansion of macro 'ATH_DUMP_BTCOEX'
501 | ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
| ^~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath9k/ath9k.h:763:3: note: each undeclared identifier is reported only once for each function it appears in
763 | len += scnprintf(buf + len, size - len, \
| ^~~
drivers/net/wireless/ath/ath9k/gpio.c:501:2: note: in expansion of macro 'ATH_DUMP_BTCOEX'
501 | ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
| ^~~~~~~~~~~~~~~
make[5]: *** [drivers/net/wireless/ath/ath9k/gpio.o] Error 1
make[4]: *** [drivers/net/wireless/ath/ath9k] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210224130356.51444-1-zhangkun4jr@163.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-04-21 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 13:03 [PATCH] ath9k:remove unneeded variable in ath9k_dump_legacy_btcoex zhangkun4jr
2021-04-21 17:46 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421174610.B4FD1C433F1@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhangkun4jr@163.com \
--cc=zhangkun@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).