From: Stephen Hemminger <stephen@networkplumber.org>
To: Jethro Beekman <kernel@jbeekman.nl>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] ip: Clarify MACVLAN private mode
Date: Mon, 26 Apr 2021 21:02:33 -0700 [thread overview]
Message-ID: <20210426210233.7941b7f1@hermes.local> (raw)
In-Reply-To: <8685da8c-3502-34c7-c91f-db28a0a450d6@jbeekman.nl>
On Sat, 24 Apr 2021 23:28:52 +0200
Jethro Beekman <kernel@jbeekman.nl> wrote:
> Traffic isn't really "disallowed" but rather some broadcast traffic is filtered.
>
> Signed-off-by: Jethro Beekman <kernel@jbeekman.nl>
> ---
> man/man8/ip-link.8.in | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
> index fd67e611..a4abae5f 100644
> --- a/man/man8/ip-link.8.in
> +++ b/man/man8/ip-link.8.in
> @@ -1366,10 +1366,12 @@ the following additional arguments are supported:
> .BR /dev/tapX " to be used just like a " tuntap " device."
>
> .B mode private
> -- Do not allow communication between
> +- Do not allow broadcast communication between
> .B macvlan
> instances on the same physical interface, even if the external switch supports
> -hairpin mode.
> +hairpin mode. Unicast traffic is transmitted over the physical interface as in
> +.B vepa
> +mode, but the lack of ARP responses may hamper communication.
The grammar here is a little awkward. It is using passive voice and the two clauses
in compound sentence don't match. Let me consult the grammar expert (my spouse is
a writer) and reword this in next release.
> .B mode vepa
> - Virtual Ethernet Port Aggregator mode. Data from one
> @@ -1394,7 +1396,7 @@ forces the underlying interface into promiscuous mode. Passing the
> using standard tools.
>
> .B mode source
> -- allows one to set a list of allowed mac address, which is used to match
> +- Allows one to set a list of allowed mac address, which is used to match
> against source mac address from received frames on underlying interface. This
> allows creating mac based VLAN associations, instead of standard port or tag
> based. The feature is useful to deploy 802.1x mac based behavior,
The original is also awkward wording here. Lets get rid of passive voice as well.
prev parent reply other threads:[~2021-04-27 4:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 21:28 [PATCH iproute2-next] ip: Clarify MACVLAN private mode Jethro Beekman
2021-04-27 4:02 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210426210233.7941b7f1@hermes.local \
--to=stephen@networkplumber.org \
--cc=kernel@jbeekman.nl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).