From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3075FC433B4 for ; Tue, 27 Apr 2021 20:35:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F27D5613F7 for ; Tue, 27 Apr 2021 20:35:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238905AbhD0UgQ (ORCPT ); Tue, 27 Apr 2021 16:36:16 -0400 Received: from mail.netfilter.org ([217.70.188.207]:54170 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237055AbhD0UgO (ORCPT ); Tue, 27 Apr 2021 16:36:14 -0400 Received: from us.es (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id 12F3763E81; Tue, 27 Apr 2021 22:34:50 +0200 (CEST) Date: Tue, 27 Apr 2021 22:35:25 +0200 From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , Arnd Bergmann , Balazs Scheidler , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] netfilter: nft_socket: fix an unused variable warning Message-ID: <20210427203525.GA14154@salvia> References: <20210427194528.2325108-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210427194528.2325108-1-arnd@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 27, 2021 at 09:45:18PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The variable is only used in an #ifdef, causing a harmless warning: > > net/netfilter/nft_socket.c: In function 'nft_socket_init': > net/netfilter/nft_socket.c:137:27: error: unused variable 'level' [-Werror=unused-variable] > 137 | unsigned int len, level; > | ^~~~~ > > Move it into the same #ifdef block. Applied, thanks Arnd.