Re: [PATCH net-next 0/4] MT7530 interrupt support

Andrew Lunn
2021-04-30T12:24:35Z

On Fri, Apr 30, 2021 at 10:38:39AM +0800, DENG Qingfang wrote:
> On Thu, Apr 29, 2021 at 05:08:15PM -0700, David Miller wrote:
> >
> > Please fix this:
> >
> > error: the following would cause module name conflict:
> > drivers/net/phy/mediatek.ko
> > drivers/usb/musb/mediatek.ko
>
> So I still have to rename the PHY driver..
> Andrew, what is your suggestion? Is mediatek_phy.c okay?

mediatek_phy.c gets you into trouble with the generic PHY drivers.
Most Ethernet PHY drivers have the model number in the file name. Does
the PHY have its own name/numbering, or is it always considered part
of the switch? If the PHY has an identity of its own, use
that. Otherwise maybe mediatek75xx.c?

Andrew