From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5CFBC43460 for ; Fri, 7 May 2021 07:59:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88FC361430 for ; Fri, 7 May 2021 07:59:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235089AbhEGIAu (ORCPT ); Fri, 7 May 2021 04:00:50 -0400 Received: from mail.netfilter.org ([217.70.188.207]:48334 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233730AbhEGIAs (ORCPT ); Fri, 7 May 2021 04:00:48 -0400 Received: from us.es (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id B2E376414B; Fri, 7 May 2021 09:59:02 +0200 (CEST) Date: Fri, 7 May 2021 09:59:45 +0200 From: Pablo Neira Ayuso To: Eric Dumazet Cc: Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, netdev , Eric Dumazet Subject: Re: [PATCH net 2/2] netfilter: nf_tables: avoid potential overflows on 32bit arches Message-ID: <20210507075945.GB4320@salvia> References: <20210506125350.3887306-1-eric.dumazet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210506125350.3887306-1-eric.dumazet@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, May 06, 2021 at 05:53:50AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > User space could ask for very large hash tables, we need to make sure > our size computations wont overflow. > > nf_tables_newset() needs to double check the u64 size > will fit into size_t field. Also applied, thannks.