From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73DC0C433ED for ; Mon, 17 May 2021 10:10:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55FF361209 for ; Mon, 17 May 2021 10:10:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236229AbhEQKLx (ORCPT ); Mon, 17 May 2021 06:11:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46844 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231658AbhEQKLw (ORCPT ); Mon, 17 May 2021 06:11:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621246236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6A0XM46+U1xV6XUwh0pcSDkTEcBAHjYNGDBCWlYZWfU=; b=KiQq2lHqC96S8Q6J5ZoVd6dwxWVNAxoxrwRMNDKX7T0CPii346kAlu6y0KsrPE4+K/+icB aMztUjoAhvTQ79mG9WAjtr+9iPrU/fo6JkmEZI4QpRamcNYYe5INQrTZrU281rBSD9bo3K A1lrahk1Hko4lUTs2q4uxEW35m3lNX8= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-PtQ8zKPYMeyhl8LUZaPHzg-1; Mon, 17 May 2021 06:10:34 -0400 X-MC-Unique: PtQ8zKPYMeyhl8LUZaPHzg-1 Received: by mail-ed1-f69.google.com with SMTP id w1-20020aa7da410000b029038d323eeee3so1553485eds.8 for ; Mon, 17 May 2021 03:10:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6A0XM46+U1xV6XUwh0pcSDkTEcBAHjYNGDBCWlYZWfU=; b=NHqIV31oq8OweiDKTLWONJfN5GAv1tHyLsKXIbNq3evRj74gCoaek1o+Ksgv0RoAR/ p4Nsbg83ZLqfRzefiTqqim0dXdGd1II3rUD/C/cyrdIPLiXa4NDLWVzrCv90I+KXWHxA TnRezEs0mss6qJS8nlQg2YKTdQM7NwDUL7FcW9ch/QjfGjoZ+D347qQQ+TEBcikjVw1m a7vknpbBcx8YIbeYSK0h0zcqdmGAXLrPtJ+KN0PIXckuD/5AHpus1LXG9b4c2Taa8oW+ Lmgi0i///6fiZxyOiv0wd2Ead72MVnudAX+vWABAFl2IQqgCRgcAxvVGBRBIKATt5VUC jaJw== X-Gm-Message-State: AOAM532XfD9Qzz9HBl3m9k8BQDEtVa53rCp3u7TSBcW4Z3m9EWPjpswB gmoRzcOyIvZ17pWzOooamOAM3sZW4vaJUgABSYd/xJoNuo2xVqZ7hRsiqJ6YuWWjn40GWg5pdol R2nDyvteZBoQTy+Af X-Received: by 2002:a17:906:2dd3:: with SMTP id h19mr4735507eji.520.1621246233746; Mon, 17 May 2021 03:10:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqlLkH+gDYYvTAUTlp87qWEwL903KJ3qvJC8eOMJstLQUpWFA2M8AcEtt0mPPMh3cfZkbN1g== X-Received: by 2002:a17:906:2dd3:: with SMTP id h19mr4735486eji.520.1621246233524; Mon, 17 May 2021 03:10:33 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id m13sm5280478eds.21.2021.05.17.03.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 03:10:33 -0700 (PDT) Date: Mon, 17 May 2021 12:10:30 +0200 From: Stefano Garzarella To: "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Gonglei (Arei)" , "Subo (Subo, Cloud Infrastructure Service Product Dept.)" , "David S . Miller" , Jakub Kicinski , Jorgen Hansen , Norbert Slusarek , Andra Paraschiv , Colin Ian King , David Brazdil , Alexander Popov , "lixianming (E)" Subject: Re: [RFC] vsock: notify server to shutdown when client has pending signal Message-ID: <20210517101030.ks2r66pyws7w7cae@steredhat> References: <20210511094127.724-1-longpeng2@huawei.com> <20210513094143.pir5vzsludut3xdc@steredhat> <558d53dd31dc4841b94c4ec35249ac80@huawei.com> <09562f9b35c3419f9b5844b35b4276ae@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <09562f9b35c3419f9b5844b35b4276ae@huawei.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, May 17, 2021 at 02:18:51AM +0000, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: >Hi Stefano, > >> -----Original Message----- >> From: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) >> [mailto:longpeng2@huawei.com] >> Sent: Thursday, May 13, 2021 6:36 PM >> To: Stefano Garzarella >> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Gonglei (Arei) >> ; Subo (Subo, Cloud Infrastructure Service Product >> Dept.) ; David S . Miller ; Jakub >> Kicinski ; Jorgen Hansen ; Norbert >> Slusarek ; Andra Paraschiv ; >> Colin Ian King ; David Brazdil >> ; Alexander Popov ; >> lixianming (E) >> Subject: RE: [RFC] vsock: notify server to shutdown when client has pending >> signal >> >> Hi Stefano, >> >> > -----Original Message----- >> > From: Stefano Garzarella [mailto:sgarzare@redhat.com] >> > Sent: Thursday, May 13, 2021 5:42 PM >> > To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) >> > >> > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Gonglei >> > (Arei) ; Subo (Subo, Cloud Infrastructure >> > Service Product >> > Dept.) ; David S . Miller ; >> > Jakub Kicinski ; Jorgen Hansen ; >> > Norbert Slusarek ; Andra Paraschiv >> > ; Colin Ian King ; >> > David Brazdil ; Alexander Popov >> > ; lixianming (E) >> > Subject: Re: [RFC] vsock: notify server to shutdown when client has >> > pending signal >> > >> > Hi, >> > thanks for this patch, comments below... >> > >> > On Tue, May 11, 2021 at 05:41:27PM +0800, Longpeng(Mike) wrote: >> > >The client's sk_state will be set to TCP_ESTABLISHED if the server >> > >replay the client's connect request. >> > >However, if the client has pending signal, its sk_state will be set >> > >to TCP_CLOSE without notify the server, so the server will hold the >> > >corrupt connection. >> > > >> > > client server >> > > >> > >1. sk_state=TCP_SYN_SENT | >> > >2. call ->connect() | >> > >3. wait reply | >> > > | 4. sk_state=TCP_ESTABLISHED >> > > | 5. insert to connected list >> > > | 6. reply to the client >> > >7. sk_state=TCP_ESTABLISHED | >> > >8. insert to connected list | >> > >9. *signal pending* <--------------------- the user kill client >> > >10. sk_state=TCP_CLOSE | >> > >client is exiting... | >> > >11. call ->release() | >> > > virtio_transport_close >> > > if (!(sk->sk_state == TCP_ESTABLISHED || >> > > sk->sk_state == TCP_CLOSING)) >> > > return true; <------------- return at here As a result, the server >> > >cannot notice the connection is corrupt. >> > >So the client should notify the peer in this case. >> > > >> > >Cc: David S. Miller >> > >Cc: Jakub Kicinski >> > >Cc: Stefano Garzarella >> > >Cc: Jorgen Hansen >> > >Cc: Norbert Slusarek >> > >Cc: Andra Paraschiv >> > >Cc: Colin Ian King >> > >Cc: David Brazdil >> > >Cc: Alexander Popov >> > >Signed-off-by: lixianming >> > >Signed-off-by: Longpeng(Mike) >> > >--- >> > > net/vmw_vsock/af_vsock.c | 1 + >> > > 1 file changed, 1 insertion(+) >> > > >> > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >> > >index >> > >92a72f0..d5df908 100644 >> > >--- a/net/vmw_vsock/af_vsock.c >> > >+++ b/net/vmw_vsock/af_vsock.c >> > >@@ -1368,6 +1368,7 @@ static int vsock_stream_connect(struct socket >> > >*sock, >> > struct sockaddr *addr, >> > > lock_sock(sk); >> > > >> > > if (signal_pending(current)) { >> > >+ vsock_send_shutdown(sk, SHUTDOWN_MASK); >> > >> > I see the issue, but I'm not sure is okay to send the shutdown in any >> > case, think about the server didn't setup the connection. >> > >> > Maybe is better to set TCP_CLOSING if the socket state was >> > TCP_ESTABLISHED, so the shutdown will be handled by the >> > transport->release() as usual. >> > >> > What do you think? >> > >> >> Your method looks more gracefully, we'll try it and get back to you, >> thanks. >> > >As your suggestion, the following code can solve the problem: > > if (signal_pending(current)) { > err = sock_intr_errno(timeout); >- sk->sk_state = TCP_CLOSE; >+ sk->sk_state = TCP_CLOSING; > sock->state = SS_UNCONNECTED; > vsock_transport_cancel_pkt(vsk); > goto out_wait; > >This will send shutdown to the server even if the connection is not established, but >I don't see any side effects yet, right ? Should we set TCP_CLOSING only if sk_state was TCP_ESTABLISHED? > >The problem is also in the timeout case, we should fix it together ? > I'm not sure, if we reach the timeout, it should mean that the other peer never answered, so why take care to notify it? Thanks, Stefano