From: Ezequiel Garcia <ezequiel@collabora.com>
To: netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org
Cc: Jose Abreu <joabreu@synopsys.com>,
Heiko Stuebner <heiko@sntech.de>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Peter Geis <pgwipeout@gmail.com>,
Kever Yang <kever.yang@rock-chips.com>,
David Wu <david.wu@rock-chips.com>,
Rob Herring <robh+dt@kernel.org>,
Johan Jonker <jbx6244@gmail.com>,
Chen-Yu Tsai <wens213@gmail.com>,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH v3 net-next 1/4] net: stmmac: Don't set has_gmac if has_gmac4 is set
Date: Mon, 17 May 2021 12:40:34 -0300 [thread overview]
Message-ID: <20210517154037.37946-2-ezequiel@collabora.com> (raw)
In-Reply-To: <20210517154037.37946-1-ezequiel@collabora.com>
Some Rockchip platforms have a GMAC4 core, and therefore
'plat_stmmacenet_data.has_gmac' shouldn't be set if
'plat_stmmacenet_data.has_gmac4' is set.
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index 584db4ce6e39..56034f21fcef 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -1448,7 +1448,11 @@ static int rk_gmac_probe(struct platform_device *pdev)
if (IS_ERR(plat_dat))
return PTR_ERR(plat_dat);
- plat_dat->has_gmac = true;
+ /* If the stmmac is not already selected as gmac4,
+ * then make sure we fallback to gmac.
+ */
+ if (!plat_dat->has_gmac4)
+ plat_dat->has_gmac = true;
plat_dat->fix_mac_speed = rk_fix_speed;
plat_dat->bsp_priv = rk_gmac_setup(pdev, plat_dat, data);
--
2.30.0
next prev parent reply other threads:[~2021-05-17 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 15:40 [PATCH v3 net-next 0/4] net: stmmac: RK3568 Ezequiel Garcia
2021-05-17 15:40 ` Ezequiel Garcia [this message]
2021-05-17 15:40 ` [PATCH v3 net-next 2/4] net: stmmac: dwmac-rk: Check platform-specific ops Ezequiel Garcia
2021-05-17 15:40 ` [PATCH v3 net-next 3/4] dt-bindings: net: rockchip-dwmac: add rk3568 compatible string Ezequiel Garcia
2021-05-17 15:40 ` [PATCH v3 net-next 4/4] net: stmmac: Add RK3566/RK3568 SoC support Ezequiel Garcia
2021-05-17 22:50 ` [PATCH v3 net-next 0/4] net: stmmac: RK3568 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517154037.37946-2-ezequiel@collabora.com \
--to=ezequiel@collabora.com \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kever.yang@rock-chips.com \
--cc=kuba@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens213@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).